Skip to content

Profiler: load_method hotfix #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorfturner merged 4 commits into from
Jun 29, 2023
Merged

Profiler: load_method hotfix #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b84f94d
added load_method
micdavis Jun 28, 2023
f92c33c
updated tests
micdavis Jun 28, 2023
9e0873c
small fix
micdavis Jun 28, 2023
c695a40
set load_method to default to none
micdavis Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions dataprofiler/profilers/profile_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1162,12 +1162,14 @@ def save(self, filepath: str = None, save_method: str = "pickle") -> None:
raise NotImplementedError()

@classmethod
def load(cls, filepath: str, load_method: str | None = "pickle") -> BaseProfiler:
def load(cls, filepath: str, load_method: str | None = None) -> BaseProfiler:
"""
Load profiler from disk.

:param filepath: Path of file to load from
:type filepath: String
:param load_method: The desired loading method, default = None
:type load_method: Optional[String]
:return: Profiler being loaded, StructuredProfiler or
UnstructuredProfiler
:rtype: BaseProfiler
Expand Down Expand Up @@ -2991,14 +2993,17 @@ def __new__( # type: ignore
)

@classmethod
def load(cls, filepath: str) -> BaseProfiler:
def load(cls, filepath: str, load_method: str | None = None) -> BaseProfiler:
"""
Load profiler from disk.

:param filepath: Path of file to load from
:type filepath: String
:param load_method: The desired loading method, default = "None"
:type load_method: Optional[String]

:return: Profiler being loaded, StructuredProfiler or
UnstructuredProfiler
:rtype: BaseProfiler
"""
return BaseProfiler.load(filepath)
return BaseProfiler.load(filepath, load_method)
2 changes: 1 addition & 1 deletion dataprofiler/tests/profilers/test_profile_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4450,7 +4450,7 @@ def test_save_and_load_structured(self):
"dataprofiler.profilers.profile_builder." "DataLabeler",
return_value=data_labeler,
):
load_profile = dp.Profiler.load("mock.pkl")
load_profile = dp.Profiler.load("mock.pkl", load_method="PICKLE")

# validate loaded profile has same data labeler class
self.assertIsInstance(
Expand Down