Skip to content

Comments

Docs: Profiler Serialization#928

Merged
taylorfturner merged 5 commits intocapitalone:feature/dev-gh-pages/profile-serializationfrom
micdavis:profiler_serialization_docs
Jun 28, 2023
Merged

Docs: Profiler Serialization#928
taylorfturner merged 5 commits intocapitalone:feature/dev-gh-pages/profile-serializationfrom
micdavis:profiler_serialization_docs

Conversation

@micdavis
Copy link
Contributor

  • updated the save and load section of the profiler.rst to reflect the new json serialization

@taylorfturner taylorfturner added the Documentation Improvements or additions to documentation label Jun 28, 2023
@taylorfturner taylorfturner enabled auto-merge (squash) June 28, 2023 21:21
Comment on lines 286 to 292
* **pickle save/load**
* save a profile as a pkl file.
* load a pkl file as a profile object.

* **json save/load**
* save a profile as a human-readable json file.
* load a json file as a profile object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **pickle save/load**
* save a profile as a pkl file.
* load a pkl file as a profile object.
* **json save/load**
* save a profile as a human-readable json file.
* load a json file as a profile object.
* **Pickle save/load**
* Save a profile as a `.pkl` file.
* Load a `.pkl` file as a profile object.
* **Json save/load**
* Save a profile as a human-readable json file.
* Load a json file as a profile object.

* save a profile as a human-readable json file.
* load a json file as a profile object.

**NOTE: json saving and loading isn't supported for unstructured profiles.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**NOTE: json saving and loading isn't supported for unstructured profiles.**
**NOTE: Unstructured profiles do not support JSON saving and loading.**


**NOTE: json saving and loading isn't supported for unstructured profiles.**

.. code-block:: python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend another code-block too for JSON save / load example too ... could just write up an example since we know top-level API

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines +810 to +831

* unique_count - (UniqueCountOptions) Option to enable/disable unique row count calculations

* is_enabled - (Bool) Enables or disables options for unique row count
* hashing_method - (String) Property to specify row hashing method ("full" | "hll")
* hll - (HyperLogLogOptions) Options for alternative method of estimating unique row count (activated when `hll` is the selected hashing_method)

* seed - (Int) Used to set HLL hashing function seed
* register_count - (Int) Number of registers is equal to 2^register_count

* null_count - (Boolean) Option to enable/disable functionalities for row_has_null_ratio and row_is_null_ratio
* **chi2_homogeneity** - Options for the chi-squared test matrix

* is_enabled - (Boolean) Enables or disables performing chi-squared tests for homogeneity between the categorical columns of the dataset.
* **null_replication_metrics** - Options for calculating null replication metrics

* is_enabled - (Boolean) Enables or disables calculation of null replication metrics
* **unstructured_options** - Options responsible for all unstructured data * **chi2_homogeneity** - Options for the chi-squared test matrix

* is_enabled - (Boolean) Enables or disables performing chi-squared tests for homogeneity between the categorical columns of the dataset.
* **null_replication_metrics** - Options for calculating null replication metrics

Copy link
Contributor

@taylorfturner taylorfturner Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is okay to be in here ... I pushed this rendering fix to staging/dev-gh-pages/profile-serialization which is why it is not in feature/dev-gh-pages/profile-serialization

taylorfturner
taylorfturner previously approved these changes Jun 28, 2023

There are two save/load methods:

* **Pickle save/load**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

print(json.dumps(loaded_pkl_profile.report(report_options={"output_format": "compact"}),
indent=4))

* **Json save/load**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>
@taylorfturner
Copy link
Contributor

Pending #925

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>
auto-merge was automatically disabled June 28, 2023 23:26

Pull request was closed

@taylorfturner taylorfturner reopened this Jun 28, 2023
@taylorfturner taylorfturner merged commit 2518dc5 into capitalone:feature/dev-gh-pages/profile-serialization Jun 28, 2023
micdavis added a commit that referenced this pull request Jun 29, 2023
* added info to profile save and load func

* addressed PR comments

* fixed formatting

* Update docs/source/profiler.rst

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

* Update docs/source/profiler.rst

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

---------

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>
micdavis added a commit that referenced this pull request Jun 29, 2023
* added info to profile save and load func

* addressed PR comments

* fixed formatting

* Update docs/source/profiler.rst

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

* Update docs/source/profiler.rst

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

---------

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>
taylorfturner added a commit that referenced this pull request Jun 29, 2023
#937)

* Docs: Profiler Serialization (#928)

* added info to profile save and load func

* addressed PR comments

* fixed formatting

* Update docs/source/profiler.rst

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

* Update docs/source/profiler.rst

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

---------

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

* fixed formatting in docs (#936)

---------

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>
JGSweets added a commit that referenced this pull request Jun 30, 2023
* documentation update for cms specific options to category (#917)

* add cms specific options to category

* address formatting requests

* address formatting requests

* Documentation: Update for Reservoir Sampling (#919)

* update option for reservoir sampling

* update for clarity rendering

* Documentation: feature/options branch docs updates (#921)

* reset ignore, update .gitignore, update documentation on presets (#874)

* reset ignore

* taylor's requested change

* taylor's requested change

* Fixed documentation for `sampling_ratio` option (#873)

* Add documentation for `sampling_ratio` option

* Update `sample_ratio` to `sampling_ratio` in documentations

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

* Update `sampling_ratio` documentation

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

* Update `sampling_ratio` documentation

* Updated `sampling_ratio` documentation

* Updated `sampling_ratio` documentation

* Updated `sampling_ratio` documentation

---------

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

* update (#882)

* Add documentation for `median_abs_deviation` option (#881)

* Add documentation for `median_abs_deviation` option

* Updated `median_abs_deviation` documentation

* Row statistics option documentation (#883)

* updated documentation on new row_statistic options

* added documentation for row_statistics_options

* fixed typing of hll and included the note that it activates when hll is chosen as the hashing method

* removed space

* fixed quotation mark

* added micdavis comments

* fixed doc descriptions for unique_count

* small changes to docs

---------

Co-authored-by: JGSweets <JGSweets@users.noreply.github.com>

* rendering issue

* rendering issue

* update to fix rendering

---------

Co-authored-by: Liz Smith <liz.smith@richmond.edu>
Co-authored-by: clee1152 <72765198+clee1152@users.noreply.github.com>
Co-authored-by: Richard Bann <87214439+drahc1R@users.noreply.github.com>
Co-authored-by: JGSweets <JGSweets@users.noreply.github.com>

* fix req tornado (#922)

* Merge `staging/dev-gh-pages/profile-serialization` into `dev-gh-pages` (#937)

* Docs: Profiler Serialization (#928)

* added info to profile save and load func

* addressed PR comments

* fixed formatting

* Update docs/source/profiler.rst

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

* Update docs/source/profiler.rst

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

---------

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

* fixed formatting in docs (#936)

---------

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

* Staging update docs 0.10.0  (#945)

* update or 0.10.0 docs version release

* empty

---------

Co-authored-by: Tyler <tfarnan@ucsd.edu>
Co-authored-by: Liz Smith <liz.smith@richmond.edu>
Co-authored-by: clee1152 <72765198+clee1152@users.noreply.github.com>
Co-authored-by: Richard Bann <87214439+drahc1R@users.noreply.github.com>
Co-authored-by: JGSweets <JGSweets@users.noreply.github.com>
Co-authored-by: Michael Davis <36012613+micdavis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants