Encode Options

[micdavis]

• Enabled Options to be encoded to json
• Wrote tests for all Options except ProfileOptions and UnstructuredOptions

[micdavis]

does this test need to be more robust?

[ksneab7]

I dont think so now, but it might beed to be expanded to include the from_disk once that is implemented.

[taylorfturner]

this is a bit wonk

[taylorfturner]

feature/options update will fail

[taylorfturner]

naming

[taylorfturner]

LGTM

updated

[JGSweets]

I just tested a theory that actually cleans up the code quite a bit. Not sure if it is better than just the deserial we were going to do, but:

    def test_json_encode(self):
        option = UnstructuredOptions()

        serialized = json.dumps(option, cls=ProfileEncoder)

        expected_json = {
            "class": "UnstructuredOptions",
            "data": {
                "text": {"class": "TextProfilerOptions", "data": mock.ANY},
                "data_labeler": {"class": "DataLabelerOptions", "data": mock.ANY},
            }
        }

        actual_option_json = json.loads(serialized)
        self.assertDictEqual(expected_json, actual_option_json)

[JGSweets]

the mock.ANY will match anything in that, which we assume is correct in our cases bc of other tests.

[micdavis]

done

[JGSweets]

This isn't an issue in this PR, but i'm not sure why we save presets to self as oppose to just use it to choose them.

Food for thought of something we might want to change. Not sure why'd we serialize it is why I ask.

[JGSweets]

Also we currently don't raise an error if the preset doesn't exist. it just silently continues.

[micdavis]

self.assertIn("presets", actual_option_json["data"]) should catch it when presets doesn't exist

[taylorfturner]

Also we currently don't raise an error if the preset doesn't exist. it just silently continues.

Not quite sure that is true once everything gets merged in (i.e. feature/options). That's something that Liz added when we were adding the new preset. https://github.com/capitalone/DataProfiler/blob/feature/options/dataprofiler/profilers/profiler_options.py#L1593

[JGSweets]

self.assertIn("presets", actual_option_json["data"]) should catch it when presets doesn't exist

I'm not suggesting we need to make sure it exists, it is a comment that refers to an issue.

Not quite sure that is true once everything gets merged in (i.e. feature/options). That's something that Liz added when we were adding the new preset. https://github.com/capitalone/DataProfiler/blob/feature/options/dataprofiler/profilers/profiler_options.py#L1593

Yup, that solves the silent issue