Add Propshaft .manifest.json to assets_manifests for support
#265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
will-in-wi
approved these changes
Dec 29, 2024
Contributor
will-in-wi
left a comment
will-in-wi
left a comment
There was a problem hiding this comment.
I'm fine with this. Tough for me to test, since I don't use rollback, but I am currently deploying a Rails 8 app with Propshaft using Capistrano, so it at least works without this other than rollback.
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request adds the Propshaft manifest file (
.manifest.json) to the default value ofassets_manifests. (Fix #257)As mentioned in this comment (#257 (comment)), Propshaft support can be enabled by
adding assets_manifeststo the Capistrano configuration.However, since Propshaft has become the default asset pipeline in Rails 8.0, I believe it makes sense to include it as a default value in
capistrano-rails.Other Information
Note that the default manifest file for Propshaft is
public/assets/.manifest.json, which is static path.https://github.com/rails/propshaft/tree/main?tab=readme-ov-file#usage