Allow for specification of environment variables when bundle-ing #23
+22
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ```ruby | ||
| # This translates to NOKOGIRI_USE_SYSTEM_LIBRARIES=1 when executed | ||
| set :bundle_environment_variables, { :nokogiri_use_system_libraries => 1 } |
There was a problem hiding this comment.
Maybe get rid of the hash rocket?
|
@Kriechi - requested changes have been made! |
|
Code looks good to me. |
|
Good to go! |
|
Anything else we need to do to get this merged in? |
|
Should be ready to merge |
|
Looks good to me 👍 |
|
I'm ok to merge, but I would prefer |
…the `bundle_env_variables` configuration option.
|
ok @kirs - made the requested naming change - this is now using Let me know if you need anything else. |
kirs
added a commit
that referenced
this pull request
Jan 26, 2014
Allow for specification of environment variables when bundle-ing
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New pull request for work done previously in #21.