Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed all bundler options to be optional #18

Merged
merged 2 commits into from
Dec 11, 2013
Merged

Conversation

Kriechi
Copy link
Contributor

@Kriechi Kriechi commented Nov 23, 2013

setting one of the options to a nil-value will exclude it from the final
bundler command

based on the work of @maxmouchet

closes #3 #6 #8 #14

setting one of the options to a nil-value will exclude it from the final
bundler command
@Kriechi
Copy link
Contributor Author

Kriechi commented Nov 29, 2013

I've rebased and added a default value for the command to add additional binaries to the array (might be nil, so default to [])

this would also close #20 because the bin-mapping is in its own task with description.

@Kriechi
Copy link
Contributor Author

Kriechi commented Nov 30, 2013

@kirs any comments?

maybe we should try to cleanup most issues and PR from all capistrano-* gems, before Capistrano 3.1 gets released?

@deepsystm
Copy link

agree w/ @Kriechi

changed all bundler options to be optional!

@kirs
Copy link
Member

kirs commented Dec 11, 2013

The only thing I'm afraid of is backward capability. Maybe we should better describe it in the CHANGELOG?

@Kriechi
Copy link
Contributor Author

Kriechi commented Dec 11, 2013

I have added a section to the changelog.
The only thing breaking backward compatibility should be the bundle_dir rename to bundle_path.

kirs added a commit that referenced this pull request Dec 11, 2013
changed all bundler options to be optional
@kirs kirs merged commit f1b70e2 into capistrano:master Dec 11, 2013
@kirs
Copy link
Member

kirs commented Dec 11, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make bundling binstubs optional to match with rails 4.0 and Bundler 1.3.5
3 participants