chore: remove legacy binary build workflows and scripts#21
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes legacy binary build infrastructure for standalone Node.js executables. According to the description, the CLI has been re-engineered to wrap the capiscio-core binary, making the previous pkg-based binary build system obsolete.
Key changes:
- Removed two GitHub Actions workflows for building and testing standalone binaries
- Removed the local build script for creating binaries
- Cleaned up package.json by removing unused npm scripts and dev dependencies
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/release-binaries.yml |
Deleted workflow that built and published standalone binaries on releases |
.github/workflows/test-binaries.yml |
Deleted workflow that tested cross-platform binary builds |
scripts/build-binaries.js |
Deleted script that bundled CLI with esbuild and created binaries with pkg |
package.json |
Removed build:binaries script and unused @yao-pkg/pkg and esbuild dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the legacy CI workflows and scripts for building standalone binaries.
The CLI has been re-engineered to wrap the
capiscio-corebinary, so we no longer need to build and publish standalone Node.js binaries (pkg) in the CI pipeline.Changes:
.github/workflows/release-binaries.yml.github/workflows/test-binaries.ymlscripts/build-binaries.jspackage.jsonto remove unused scripts and dependencies (pkg,esbuild)