Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios: transform contact to JSON object instead of array to match type #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ios: transform contact to JSON object instead of array to match type #356

wants to merge 1 commit into from

Conversation

karen1au
Copy link

Currently the listener on ApplePayEventsEnum.DidCreatePaymentMethod is receiving data.contact as an array, but the type should actually be ShippingContact

@rdlabo
Copy link
Member

rdlabo commented Aug 11, 2024

Thanks pull request.
This pull request has that ApplePayEvents.DidCreatePaymentMethod.rawValue has breaking changes. and will not match requiredShippingContactFields. Being an array is not reasonable, but it makes implementation easier, so I will keep it that way.

If you have any input, please share.

@rdlabo rdlabo added the question Further information is requested label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karen1au @rdlabo