Skip to content

Conversation

@dcyou
Copy link

@dcyou dcyou commented Aug 28, 2024

Hi guys, just added some clarification.

@dcyou
Copy link
Author

dcyou commented Aug 28, 2024

also could be great to add somewhere, should be added to the project with XCode
image

@dcyou
Copy link
Author

dcyou commented Aug 28, 2024

and under Android
image

Copy link

@schemenauero schemenauero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typo and some discussion.

I was only able to get this plugin to work because of this PR! Specifically the image of the iOS setup in xcode. Thanks to all involved!


public static let ErrorAssetId = "Asset Id is missing"
public static let ErrorAssetPath = "Asset Path is missing"
public static let ErrorAssetPath = "Asset Path is missing or audio file can't be find"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static let ErrorAssetPath = "Asset Path is missing or audio file can't be find"
public static let ErrorAssetPath = "Asset Path is missing or audio file can't be found"

public static final String ERROR_AUDIO_ASSET_MISSING = "Audio Asset is missing";
public static final String ERROR_AUDIO_EXISTS = "Audio Asset already exists";
public static final String ERROR_ASSET_PATH_MISSING = "Asset Path is missing";
public static final String ERROR_ASSET_PATH_MISSING = "Asset Path is missing or audio file can't be find";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static final String ERROR_ASSET_PATH_MISSING = "Asset Path is missing or audio file can't be find";
public static final String ERROR_ASSET_PATH_MISSING = "Asset Path is missing or audio file can't be found";

```

On iOS, Android and Web, no further steps are needed.
On iOS, Android and Web, no further steps are needed by stricly following the files location then just use the filename as *assetPath*.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better but the whole line is untrue if you need to open the project in xcode to get it working

@Alvaro948
Copy link

Correct me if I am wrong but according to https://github.com/bazuka5801/native-audio-example/blob/master/src-capacitor/android/app/src/main/assets/fire.mp3 android directory is PROJECT_ROOT/android/app/src/main/assets not PROJECT_ROOT/android/app/src/assets. I have tried both, only the first one works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants