feat(): enable implicit redirect flow on web #267
Conversation
|
@moberwasserlechner , happy to work on any change you see this PR needs 😄 |
|
@tafelnl , let me know if this PR requires some changes, I'll be happy to work on it. |
|
Morning @moberwasserlechner , @tafelnl , could I get some input with this? Thank you! |
|
@eduardoRoth I try to have a look later today. |
|
@moberwasserlechner , updated my branch with your comments, I went ahead with the name |
|
@moberwasserlechner let me know if the changes are good to go or you still need more changes :D |
|
@moberwasserlechner , sorry to keep bothering you, I'd appreciate a look in this PR so I can update my client's project. |
|
Sry for the merge conflict but as you change one more thing I though it will be easier that way. I prepare the release asap after this is merged. Although the push to npm must (most probably) do @tafelnl because I do not have permissions. |
|
No worries. I'll publish when ready. Maybe the Cap team could grant you publish permissions as well |
# Conflicts: # src/web-utils.test.ts # src/web.ts
|
@moberwasserlechner @tafelnl branch updated and merge conflict resolved 😄 |
|
@tafelnl I think we're ready. I did a quick test on web, Android and IOS and at least for Google Auth the new changes are not breaking things. I added a draft release but let you publish it as soon as the new version is on npm. Thx |
|
Looks good, thanks guys. I just published the release to npm |
|
Thank you @moberwasserlechner and @tafelnl !!! 🥳🥳🥳 |
Enables the implicit redirect authentication flow for web, when using
windowTarget: '_self'Closes