Bug: # in URL causes parser to ignore ?

[ynunez]

Capacitor version:

You can use npx cap doctor for the output from the root directory of your project. -->

Run npx cap doctor:

Latest Dependencies:

  @capacitor/cli: 2.4.6
  @capacitor/core: 2.4.6
  @capacitor/android: 2.4.6
  @capacitor/electron: 2.4.6
  @capacitor/ios: 2.4.6

Installed Dependencies:

  @capacitor/cli 2.4.6
  @capacitor/android 2.4.6
  @capacitor/core 2.4.6
  @capacitor/ios 2.4.6
  @capacitor/electron not installed

Library version:

• 2.1.0

OAuth Provider:

• Other: Custom

Your Plugin Configuration

            {
                appId: 'com.digiphan.apps.eznet',
                pkceEnabled: true,
                authorizationBaseUrl: `${environment.portal.accounts}auth/${social ? social : 'login'}`,
                accessTokenEndpoint: `${environment.api.security}auth/token/access`,
                scope: "ez",
                responseType: "code",
                web: {
                    redirectUrl: `${environment.portal.accounts}`,
                    windowOptions: "height=600,width=600,left=0,top=0"
                },
                android: {
                    redirectUrl: "digiphan:/"
                },
                ios: {
                    redirectUrl: "digiphan:/"
                }
            }

Affected Platform(s):

• Web

Current Behavior

When the redirect URL contains a hash after the query params it fails to parse the parameters.

For example:

https://www.digiphan.com/auth/verify?client_id=com.digiphan.apps.eznet&response_type=code&scope=ez&state=QMVxtar1wd3EgsV7Z0UA&code_challenge=8VuJBHHnDdGtIZTA8AysVuwktmt7taZdNnw-eL8KrOU&code_challenge_method=S256&code=AUTH_CODE_HERE#_=_

Expected Behavior

It should parse the parameters after the ? and ignore the # if it's after.

Parameters should be parsed as follows for the url above

client_id=com.digiphan.apps.eznet
response_type=code
scope=ez
state=QMVxtar1wd3EgsV7Z0UA
code_challenge=8VuJBHHnDdGtIZTA8AysVuwktmt7taZdNnw-eL8KrOU
code_challenge_method=S256
code=AUTH_CODE_HERE

Reproduction Steps

It can be reproduced if the redirect url contains a hash (#) after the query params indicator (?). Below is the snippet of code that is causing it (web-utils.ts ). As you see it ignores ? if it contains a #

let idx = urlString.indexOf("#");
if (idx === -1) {
    idx = urlString.indexOf("?");
}

[moberwasserlechner]

Thanks for the PR.