Skip to content

Conversation

@vespasianvs
Copy link

With the new version, the splash screen image seems to be only 4 x 18px even though the image file is 400px x 400px and the window is also the same.

It's because the width and height css values were removed. This adds them back in so correctly size the splash screen image.

@Frooger
Copy link

Frooger commented Jan 25, 2024

Is it possible to merge this, have the same issue and I guess many people too

@Earu
Copy link

Earu commented Jan 26, 2024

I have the same issue

@hatsantos
Copy link

Same here... is there a way have this from npm? Or do i have to monkey path the node_modules source code after install?

@VladSolyony
Copy link

We still need this fix getting merged

@VladSolyony
Copy link

With the new version, the splash screen image seems to be only 4 x 18px even though the image file is 400px x 400px and the window is also the same.

It's because the width and height css values were removed. This adds them back in so correctly size the splash screen image.

maybe you should pick someone for review?

@vespasianvs
Copy link
Author

Doesn't seem to let me pick a reviewer or anything. We're currently just using our fork of Electron now with this change (and a couple of others).

@richardliebmann
Copy link

Hi @IT-MikeS,

Is there any chance of getting this merged? This is a very annoying bug that would be very easily fixed.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants