Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): add missing import #130

Merged
merged 2 commits into from
Oct 2, 2024
Merged

fix(android): add missing import #130

merged 2 commits into from
Oct 2, 2024

Conversation

robingenz
Copy link
Member

@robingenz robingenz commented Sep 24, 2024 •
edited
Loading

This PR adds a missing import.

Close #134

Related to #128

npm i @capacitor-community/contacts@6.1.0-dev.852577c.1727177586

@robingenz robingenz mentioned this pull request Sep 24, 2024
Closed
This was referenced Sep 24, 2024
Merged
Closed
@lb-ovc
Copy link

lb-ovc commented Sep 30, 2024

@robingenz when can this be reviewed?

@robingenz
Copy link
Member Author

@tafelnl Can we publish this change? The last release is unfortunately broken on Android.

@tafelnl tafelnl merged commit 5e3f53f into capacitor-community:main Oct 2, 2024
tafelnl added a commit that referenced this pull request Oct 2, 2024
@robingenz @tafelnl
feat!: update to Capacitor v6 (#133)
ddc9dc7 
Currently the Capacitor v3 implementation is on main. It would make more
sense if Capacitor v6 was the default and there was a v3 branch for
Capacitor v3.

Please merge #130, #131 and #132 first.

---------

Co-authored-by: tafelnl <35837839+tafelnl@users.noreply.github.com>
@tafelnl
Copy link
Member

tafelnl commented Oct 2, 2024

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tafelnl tafelnl tafelnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails because Logger symbol is not found
3 participants
@robingenz @lb-ovc @tafelnl