chore: Update to ORD 1.16#481
Draft
mlakov wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
The PR is a straightforward version bump of the ORD specification from 1.14 to 1.16, with consistent snapshot updates across all test suites, plus the addition of baseUrl to the generated ORD document. The version bump itself is clean and complete. However, the baseUrl field introduced in lib/ord.js is missing a corresponding entry in MERGE_STRATEGIES, which will cause a runtime crash if any customOrdContentFile also contains a baseUrl key — this should be addressed before merging.
PR Bot Information
Version: 1.21.1
- Agent Instructions:
- File Content Strategy: Full file content
- Correlation ID:
f950f5a6-33ca-4031-af23-c969f3f6a3e2 - LLM:
anthropic--claude-4.6-sonnet - Event Trigger:
pull_request.opened
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ORD Version to 1.16
Chore
🔧 Bumped the Open Resource Discovery (ORD) specification version from
1.14to1.16across the codebase.Changes
lib/defaults.js: Updated theopenResourceDiscoverydefault value from"1.14"to"1.16".lib/ord.js: AddedbaseUrlfromappConfig.env.baseUrlto the generated ORD document structure.package.json: Updated the@open-resource-discovery/specificationdev dependency from1.14.5to1.16.0.__tests__/unit/__snapshots__/defaults.test.js.snap: Updated snapshot to reflect new ORD version"1.16".__tests__/unit/__snapshots__/mocked-csn.test.js.snap: UpdatedopenResourceDiscoverysnapshots to"1.16".__tests__/unit/__snapshots__/ord.e2e.test.js.snap: Updated all relevantopenResourceDiscoverysnapshot entries to"1.16".__tests__/integration/__snapshots__/basic-auth.test.js.snap: Updated integration test snapshots to"1.16".__tests__/integration/__snapshots__/cds-build.test.js.snap: Updated integration test snapshots to"1.16".__tests__/integration/__snapshots__/mtls-auth-dev.test.js.snap: Updated integration test snapshots to"1.16".__tests__/integration/__snapshots__/mtls-auth-prod.test.js.snap: Updated integration test snapshots to"1.16".PR Bot Information
Version:
1.21.1f950f5a6-33ca-4031-af23-c969f3f6a3e2anthropic--claude-4.6-sonnetpull_request.opened