fix: signature of cds.tx

[daogrady]

Fixes internal issue 19620

Report confirmed in REPL:

[hyperspace-insights]

Summary

The following content is AI-generated and provides a summary of the pull request:

---

Fix Signature of cds.tx to Properly Infer Return Type

Bug Fix

🐛 Fixed the TypeScript type signatures of cds.tx and srv.tx so that the return type of the callback function is correctly inferred and propagated as the resolved type of the returned Promise. Previously, these overloads returned Promise<unknown> or Promise<any> regardless of the callback's return type.

Changes

• apis/services.d.ts: Updated all tx overloads in both QueryAPI and the top-level cds facade to use a generic type parameter <T>, so that tx(fn) returns Promise<T> where T is the return type of fn.
• test/typescript/apis/project/cds-services.ts: Added type-level tests to verify that cds.tx, cds.tx with context, srv.tx, and srv.tx with context all correctly resolve to Promise<number> when the callback returns a number.
• CHANGELOG.md: Documented the change — cds.tx(ƒ) now returns the return type of ƒ.

---

• 🔄 Regenerate and Update Summary
• ✏️ Insert as PR Description (deletes this comment)
• 🗑️ Delete comment

PR Bot Information

Version: 1.20.33

• Correlation ID: 1d12eac5-034a-48ba-8888-e8e5cebd4d76
• Event Trigger: pull_request.opened
• LLM: anthropic--claude-4.6-sonnet
• Output Template: Default Template
• File Content Strategy: Full file content
• Summary Prompt: Default Prompt

[hyperspace-insights]

The PR correctly improves the type signatures of cds.tx overloads to propagate the callback's return type instead of the previous opaque Promise<unknown>/Promise<any>. The main issue identified is that both the QueryAPI.tx and the top-level cds.tx signatures will produce a nested Promise<Promise<R>> when async callbacks are used — using Promise<Awaited<T>> instead of Promise<T> would fix this for both sync and async callers.

PR Bot Information

Version: 1.20.33

• Event Trigger: pull_request.opened
• LLM: anthropic--claude-4.6-sonnet
• File Content Strategy: Full file content
• Correlation ID: 1d12eac5-034a-48ba-8888-e8e5cebd4d76