Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate static .keys property #308

Merged
merged 15 commits into from
Sep 24, 2024
Merged

Generate static .keys property #308

merged 15 commits into from
Sep 24, 2024

Conversation

daogrady
Copy link
Contributor

@daogrady daogrady commented Sep 4, 2024

Fixes #294

@daogrady daogrady changed the title Generate statis .keys property Generate static .keys property Sep 4, 2024
@daogrady daogrady mentioned this pull request Sep 4, 2024
Closed
@daogrady
Copy link
Contributor Author

Hi @siarhei-murkou,

I have adjusted the .keys property as discussed to use an internal Symbol as key to make it unaccessible inside of handlers.
You can get an idea of which usage is allowed and which is not from the associated test file.
Please let me know if this covers the cases we were discussing.

Best,
Daniel

@daogrady daogrady merged commit 357486e into main Sep 24, 2024
9 checks passed
@daogrady daogrady deleted the feat/static-keys-property branch September 24, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Expose 'keys' & 'gens' as static props per each compiled CDS entity
1 participant
@daogrady