fix: associations in @cds.search are additive
#1355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change: - associations/compositions in @cds.search are additive - all other elements override the default search elements - i.e. also paths with length > 1 like `books.title` override the default search elements - virtual elements are _always_ ignored and hence do not override defaults search elements
patricebender
commented
Sep 22, 2025
| }) | ||
| }) | ||
|
|
||
| describe('include / exclude logic', () => { |
Member
Author
There was a problem hiding this comment.
Please review the newly added tests
patricebender
requested review from
BobdenOs,
David-Kunz,
danjoa,
johannes-vogel and
stewsk
as code owners
sjvans
approved these changes
Sep 30, 2025
Merged
patricebender
added a commit
that referenced
this pull request
Sep 30, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 2.5.0</summary> ## [2.5.0](db-service-v2.4.0...db-service-v2.5.0) (2025-09-30) ### Added * make hana server version accessible to sub classes ([#1263](#1263)) ([a3ccc3e](a3ccc3e)) * sets default to hana cloud if server version cannot be detected ([a3ccc3e](a3ccc3e)) ### Fixed * **`@cds.search`:** no duplicates for search along `to-many` paths ([#1341](#1341)) ([5c5f4fb](5c5f4fb)) * associations in `[@cds](https://github.com/cds).search` are additive ([#1355](#1355)) ([ea931cb](ea931cb)) * set proper element link for path into fk ([#1344](#1344)) ([9f365d3](9f365d3)) </details> <details><summary>sqlite: 2.0.3</summary> ## [2.0.3](sqlite-v2.0.2...sqlite-v2.0.3) (2025-09-30) ### Fixed * associations in `[@cds](https://github.com/cds).search` are additive ([#1355](#1355)) ([ea931cb](ea931cb)) </details> <details><summary>hana: 2.3.0</summary> ## [2.3.0](hana-v2.2.0...hana-v2.3.0) (2025-09-30) ### Added * add support for SAP HANA Tenant Management Service v2 ([#1356](#1356)) ([b4bd9f2](b4bd9f2)) * make hana server version accessible to sub classes ([#1263](#1263)) ([a3ccc3e](a3ccc3e)) * sets default to hana cloud if server version cannot be detected ([a3ccc3e](a3ccc3e)) * sort selected columns & expands before formatting sql ([#1330](#1330)) ([d81b0bf](d81b0bf)) ### Fixed * updated fuzzy search syntax to include now require search mode 'text' ([#1333](#1333)) ([1946665](1946665)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Patrice Bender <patrice.bender@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change:
books.titleoverride the default search elementscloses #1347