Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added npm files whitelist #879

Merged
merged 1 commit into from
Aug 9, 2015
Merged

Added npm files whitelist #879

merged 1 commit into from
Aug 9, 2015

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Aug 9, 2015

For smaller package. Now it contains extra coverage and nyc_output folders.
500kb -> 100kb

@TrySound
Copy link
Contributor Author

TrySound commented Aug 9, 2015

Make patch release please.

@@ -2,6 +2,9 @@
"name": "async",
"description": "Higher-order functions and common patterns for asynchronous code",
"main": "lib/async.js",
"files": [
"lib"
],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed overall, but does npm support folders in files or do you specify exact path>?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It works fine. I often do this thing.

@TrySound
Copy link
Contributor Author

TrySound commented Aug 9, 2015

What is the problem with tests?

megawac added a commit that referenced this pull request Aug 9, 2015
@megawac megawac merged commit 7d31223 into caolan:master Aug 9, 2015
megawac added a commit that referenced this pull request Aug 9, 2015
@megawac
Copy link
Collaborator

megawac commented Aug 9, 2015

Looks good:

CHANGELOG.md LICENSE      README.md    lib          package.json

node_modules/async/lib:
async.js

@TrySound
Copy link
Contributor Author

TrySound commented Aug 9, 2015

@megawac Cool! Thanks!

@aearly
Copy link
Collaborator

aearly commented Aug 9, 2015

Nice catch -- this was my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants