Skip to content

Commit

Permalink
Fix perf suite
Browse files Browse the repository at this point in the history
  • Loading branch information
megawac committed Oct 5, 2016
1 parent 75d4a2e commit 0d2dbf7
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"babel-plugin-transform-es2015-modules-commonjs": "^6.3.16",
"babel-preset-es2015": "^6.3.13",
"babelify": "^7.2.0",
"benchmark": "bestiejs/benchmark.js",
"benchmark": "^2.1.1",
"bluebird": "^2.9.32",
"chai": "^3.1.0",
"cheerio": "^0.20.0",
Expand Down
38 changes: 19 additions & 19 deletions perf/suites.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = [{
[300],
[10000]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count);
},
fn: function(async, done) {
Expand All @@ -25,7 +25,7 @@ module.exports = [{
[300],
[10000]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count);
},
fn: function(async, done) {
Expand All @@ -40,7 +40,7 @@ module.exports = [{
[300],
[10000]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count);
},
fn: function(async, done) {
Expand All @@ -56,7 +56,7 @@ module.exports = [{
[300],
[10000]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count);
},
fn: function(async, done) {
Expand All @@ -71,7 +71,7 @@ module.exports = [{
[300],
[10000]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count);
},
fn: function(async, done) {
Expand All @@ -86,7 +86,7 @@ module.exports = [{
[300],
[10000]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count);
},
fn: function(async, done) {
Expand All @@ -101,7 +101,7 @@ module.exports = [{
[300],
[10000]
],
setup: function(c) {
setup: function setup(c) {
count = c;
tasks = _.range(count);
},
Expand All @@ -119,7 +119,7 @@ module.exports = [{
[300],
[10000]
],
setup: function(c) {
setup: function setup(c) {
count = c;
tasks = _.range(count);
},
Expand All @@ -138,7 +138,7 @@ module.exports = [{
[300],
[10000]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count);
},
fn: function(async, done) {
Expand All @@ -153,7 +153,7 @@ module.exports = [{
[300],
[10000]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count);
},
fn: function(async, done) {
Expand All @@ -168,7 +168,7 @@ module.exports = [{
[300],
[10000]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count);
},
fn: function(async, done) {
Expand All @@ -183,7 +183,7 @@ module.exports = [{
[100],
[1000]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count).map(function() {
return function(cb) {
setImmediate(cb);
Expand All @@ -200,7 +200,7 @@ module.exports = [{
[100],
[1000]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count).map(function() {
return function(cb) {
setImmediate(cb);
Expand All @@ -217,7 +217,7 @@ module.exports = [{
[100],
[1000]
],
setup: function(count) {
setup: function setup(count) {
tasks = [
function(cb) {
return cb(null, 1);
Expand All @@ -241,7 +241,7 @@ module.exports = [{
[100000],
[200000]
],
setup: function(count) {
setup: function setup(count) {
tasks = count;
},
fn: function(async, done) {
Expand All @@ -266,7 +266,7 @@ module.exports = [{
args: [
[500]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count);
},
fn: function(async, done) {
Expand All @@ -282,7 +282,7 @@ module.exports = [{
args: [
[500]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count);
},
fn: function(async, done) {
Expand All @@ -298,7 +298,7 @@ module.exports = [{
args: [
[500]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count);
},
fn: function(async, done) {
Expand All @@ -314,7 +314,7 @@ module.exports = [{
args: [
[500]
],
setup: function(count) {
setup: function setup(count) {
tasks = _.range(count);
},
fn: function(async, done) {
Expand Down

2 comments on commit 0d2dbf7

@megawac
Copy link
Collaborator Author

@megawac megawac commented on 0d2dbf7 Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @jdalton are you aware of this? A couple months ago this changed: unnamed setup functions started erroring (below)

undefined:12
}};if(typeof su14756782663400=="function"){try{function (c) {
                                                        ^
SyntaxError: Unexpected token (
    at createCompiled (/home/gyeates/code/async/node_modules/benchmark/benchmark.js:1712:16)
    at clock (/home/gyeates/code/async/node_modules/benchmark/benchmark.js:1595:58)
    at clock (/home/gyeates/code/async/node_modules/benchmark/benchmark.js:1805:20)
    at new Deferred (/home/gyeates/code/async/node_modules/benchmark/benchmark.js:405:7)
    at Deferred (/home/gyeates/code/async/node_modules/benchmark/benchmark.js:402:16)
    at Benchmark.run (/home/gyeates/code/async/node_modules/benchmark/benchmark.js:2099:13)
    at execute (/home/gyeates/code/async/node_modules/benchmark/benchmark.js:860:74)
    at Timeout._onTimeout (/home/gyeates/code/async/node_modules/lodash/lodash.js:2733:43)
    at tryOnTimeout (timers.js:232:11)
    at Timer.listOnTimeout (timers.js:202:5)

@jdalton
Copy link
Contributor

@jdalton jdalton commented on 0d2dbf7 Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't aware. Thanks for the heads up!

Please sign in to comment.