Fix for issue 272 internal interface from signed assembly #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* release/1.0.2: Bump version Update changelog Document interface inheritance Allow child interfaces, to some extent Update XUnit package versions
* release/1.0.3: Bump version Update changelog Add missing RestClient.For overloads Combine headers from child interfaces
* release/1.0.6: Update changelog Default local builds to version 0.0.0 Update README to reflect changed framework requirements Actually build the unit tests Support .NET 4.0, by referencing appropriate NuGet packages URLEncode path parameters
* release/1.0.9: Update changelog Encode space correctly in path parameters Add FAQ about thread safety.
* release/1.0.10: Update changelog Change my mind on whether to escape / in path params
* release/1.0.11: Update changelog Bleh, fix my test
* release/1.1.0: Update changelog Don't need System.Collections.Specialised Update the README to reflect .NET Core and move back to symbolsource Pretty sure we don't need xunit.runner.console Fix missing documentation warnings Fix up .gitattributes Fix up the rakefile Fix up the unit tests Playing around with pulling out #ifs Build xmldoc netcore migration
* release/1.1.1: Update changelog Change net45 dependency from Microsoft.Net.Http to System.Net.Http
* release/1.1.2: Update changelog Remove dependency on System.Net.Http NuGet package
* release/1.2.1: Update changelog Fix .nuspec generation from project.json
* release/1.2.2: Update changelog Fix summary/description mixup
* release/1.4.0: Update changelog Improve the Quick Start, so it's a copy-pastable application Fix the table of contents, after GitHub changed their markdown parser More refactorings Add some request info to ApiException Work around Mono/Xmarin issue with double ?? in query strings Bump date in license Add rake task to restore packages Ensure symbols package is created Fix version bumping, and remove PropertyInfo.cs Take advantage of C# 7 features (and some C# 6 features) Remove net40-specific workarounds Progress... At the expense of losing .NET 4.0 Playing with migrating to csproj
* release/1.4.1: Update changelog Change where the RestClient.For(Type) hackery happens Turns out I can lose a couple of dependencies! Add support for IRequester properties, and document extension method usage Update moq Use Assert.Null correctly Fix a bug where unicode characters were incorrectly double-encoded Add 'RestClient.For' overload which takes a Type object Store generated types in the type system rather than a dictionary Remove .NET 4.0 support claim from README Add missing fields to csproj
* release/1.4.2: Update changelog Reduce json.net dependency version to 6.0.1 for net45 Allow an IFormatProvider to be specified Use some more C# 7 features The updates serializers / deserializers shouldn't allow the old method to be implemented Pass the IRequestInfo to all serializers and deserializers Move to abstract base classes for the custom serializers and deserializers Set the MethodInfo in the RequestInfo constructor Refactor to use RuntimeMethodHandles Expose the MethodInfo of the method which was called on the IRequestInfo Add RestClient.For(Type, IRequester) overload Test for unicode escaping in path parameters
* release/1.4.3: Update changelog Add a note saying that the interface can be put in a namespace Make it clearer that iOS isn't supposed Add documentation on when to reuse instances Add support for Task<Stream> responses
* release/1.4.4: Update changelog Name the type which hasn't implemented a serializer/deserializer method Make sure that RequestVoidAsync disposes the HttpResponseMessage Don't throw if a header could be applied to content, but there is no content Add a (probably unnecessary) test around null query params Fix Samples
* release/1.4.6: Update changelog Reflect optional parameters in implementation for IronPython Add SourceLink support Support netstandard2.0 as a separate target Support generic methods Centralise tostring logic Save ApiException information to Exception.Data Support byte[] bodies If type creation files, make sure all subsequent attempts throw the same exception Fix up style, and tidy up constructor chaining Fixed ignored QueryAttribute.Name when set using property setter ([Query(Name = "customName"))
* release/1.4.8: Update changelog Clarify README around using IRequester directly Handle HttpResponseMessage.Content being null Fix method name in README ModifyingClientHttpHandler needs ConfigureAwait(false) Suffix name for type with additional assembly name Fix typo in README
* release/1.4.9: (36 commits) Update changelog Allow content headers on a null [Body] QueryStringBuilder.Build should be abstract Minor tweaks Tweak the README a bit Remove dependency on System.ComponentModel.DataAnnotations Pass FormatProvider to all serializers, for consistency Make IFormatProvider available to path serializers Check for null in enum serializer Add note about evaluation order for enum path parameter serializer in README Clean up enum path parameter serializer Add path parameter serializer specialized for enums Remove redundant definition of NETSTANDARD defines Turn PathParameterInfo into an abstract class Update README Move using statement to correct position Enable running tests under .NET Core 1.0 Make RequestPathParamSerializer generic Update README to match new definition of RequestPathParamSerializer Improve design of RequestPathParamSerializer ...
* release/1.4.10: Update changelog Bump sourcelink version; tweak license means Bump copyright year Fix typo in README Add [BasePath] attribute
* release/1.5.5: Update changelog Bump System.Net.Http version to fix CVE-2018-8292 Check the CancellationToken in the SG Use a SyntaxReceiver in the SG
* release/1.6.2: Update CHANGELOG Remove obsolete VSIX Use fully-qualified type names in generated file names Squish a bunch of build warnings
* release/1.6.4: Update CHANGELOG Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue 272 when you try to instantiate a service for an internal interface the check is perfomed, if the assembly of the interface has an InternalsVisibleTo(RestClient.FactoryAssemblyName) attribute.
Additionally to present check for presense of the InternalsVisibleTo(RestClient.FactoryAssemblyName) check if InternalsVisibleTo(RestClient.FactoryAssemblyName + ', PublicKey=') exists