Skip to content

Fix baseline grid toggle styling on standalone examples - #5684

Closed
Nayab-Gauhar wants to merge 1 commit into
canonical:mainfrom
Nayab-Gauhar:patch-5
Closed

Nayab-Gauhar wants to merge 1 commit into
canonical:mainfrom
Nayab-Gauhar:patch-5

Conversation

@Nayab-Gauhar

Copy link
Copy Markdown

Import switch component styles in examples.scss to properly style the baseline grid toggle on standalone examples.

Fixes #5286

Done

  • Added @include vf-p-switch; to scss/docs/example.scss to import switch component styles
  • This ensures the baseline grid toggle is properly styled on all standalone examples

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Bug 🐛
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • This can be a bugfix release (x.x.X) as no APIs are changed
  • Changes to component class names or macros should be listed on the what's new page (N/A for this PR - no class changes)

Screenshots

N/A - This fix only imports existing switch component styles, no visual changes to document

Import switch component styles in examples.scss to properly style the baseline grid toggle on standalone examples.

Fixes canonical#5286
@webteam-app

Copy link
Copy Markdown

Nayab-Gauhar is not a collaborator of the repo

@jmuzina jmuzina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Nayab-Gauhar , thanks for your interest!

This causes the build to fail; see CI logs.

I'd suggest checking out /guides/hacking.md and running the project locally, with dotrun to start the project and dotrun watch in another terminal so you can live-refresh SCSS changes. Please make sure the PR builds. Let me know if you have any questions :)

@jmuzina

jmuzina commented Dec 1, 2025

Copy link
Copy Markdown
Member

Closing for now - feel free to reopen once above comment is addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Baseline grid toggle is unstyled on standalone examples

3 participants