repo: allow for pre_enable messaging interactions #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackboxsw
force-pushed
the
feature/repo-pre-enable-messaging-hooks
branch
4 times, most recently
from
215aaa7
to
a5fadb4
Compare
patriciadomin
approved these changes
Apr 22, 2020
patriciadomin
approved these changes
Apr 22, 2020
patriciadomin
approved these changes
Apr 22, 2020
blackboxsw
force-pushed
the
feature/repo-pre-enable-messaging-hooks
branch
from
a5fadb4
to
3a21228
Compare
Consolidate messging hook processing under a single function handle_message_operations This is groundwork for FIPS pre-enable and pre-disable custom messaging and prompts for canonical#1031.
blackboxsw
force-pushed
the
feature/repo-pre-enable-messaging-hooks
branch
from
3a21228
to
a44a59e
Compare
powersj
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate messaging hook processing under a single function
handle_message_operations.
Make messaging an instance property so it can dynamically leverage instance variables at runtime.
This is groundwork for FIPS pre-enable and pre-disable custom
messaging and prompts for #1031.
As a note, the final branch for the prompt features which contains this PR will be this branch:
https://github.com/blackboxsw/ubuntu-advantage-client/tree/feature/fips-support