Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new flake8-xenial and bionic tox constraints for pyflakes #1023

Closed
blackboxsw opened this issue Apr 2, 2020 · 0 comments · Fixed by #1038
Closed

Add new flake8-xenial and bionic tox constraints for pyflakes #1023

blackboxsw opened this issue Apr 2, 2020 · 0 comments · Fixed by #1038
Labels
testing Testing related items

Comments

@blackboxsw
Copy link
Collaborator

Pin pyflakes==2.1.0 for new tox environments named flake8-xenial-dev and flake8-bionic-dev.

Default tox env list should include flake8-(xenial|bionic)-dev environments and omit flake8-xenial and flake8-bionic

The environments flake8-xenial and flake8-bionic will retain the actual dependency versions in those series and can only be run directly from xenial and bionic systems.

Otherwise on Focal you will see:the following Trace:

  File "/home/bryce/ubuntu/UATools/ubuntu-advantage-tools-20.3/.tox/flake8-xenial/lib/python3.8/site-packages/pyflakes/checker.py", line 462, in getNodeHandler
    self._nodeHandlers[node_class] = handler = getattr(self, nodeType)
AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'
ERROR: InvocationError for command /home/bryce/ubuntu/UATools/ubuntu-advantage-tools-20.3/.tox/flake8-xenial/bin/flake8 uaclient setup.py (exited with code 1)
@blackboxsw blackboxsw added the testing Testing related items label Apr 15, 2020
@blackboxsw blackboxsw changed the title Add new flake8-xenial-dev and flake8-bionic-dev tox environments to allow testing of xenial on Focal (python 3.8) Add new flake8-xenial and bionic tox constraints for pytest Apr 21, 2020
@blackboxsw blackboxsw changed the title Add new flake8-xenial and bionic tox constraints for pytest Add new flake8-xenial and bionic tox constraints for pyflakes Apr 21, 2020
blackboxsw added a commit to blackboxsw/ubuntu-advantage-client that referenced this issue Apr 21, 2020
@blackboxsw
tox.ini: bump pyflakes version to 2.1.1
ddbadd8 
pyflakes versions older than 2.1.0 are incompatible with Python 3.8
(which is the Python version in the Focal release).
See PyCQA/pyflakes#367 for details.

2.1.1 is the latest version ATM, so bump to that.

Fixes: canonical#1023
@blackboxsw blackboxsw mentioned this issue Apr 21, 2020
Merged
blackboxsw added a commit to blackboxsw/ubuntu-advantage-client that referenced this issue Apr 22, 2020
@blackboxsw
tox.ini: bump pyflakes version to 2.1.1
769ce0f 
pyflakes versions older than 2.1.0 are incompatible with Python 3.8
(which is the Python version in the Focal release).
See PyCQA/pyflakes#367 for details.

2.1.1 is the latest version ATM, so bump to that.

Fixes: canonical#1023
blackboxsw added a commit to blackboxsw/ubuntu-advantage-client that referenced this issue Apr 22, 2020
@blackboxsw
tox.ini: bump pyflakes version to 2.2.0
0015626 
pyflakes versions older than 2.1.0 are incompatible with Python 3.8
(which is the Python version in the Focal release).
See PyCQA/pyflakes#367 for details.

2.2.0 is the latest version ATM, so bump to that.

Fixes: canonical#1023
blackboxsw added a commit to blackboxsw/ubuntu-advantage-client that referenced this issue Apr 22, 2020
@blackboxsw
tox.ini: bump pyflakes version to 2.2.0
1a58d7a 
pyflakes versions older than 2.1.0 are incompatible with Python 3.8
(which is the Python version in the Focal release).
See PyCQA/pyflakes#367 for details.

2.2.0 is the latest version ATM, so bump to that.

Fixes: canonical#1023
powersj pushed a commit that referenced this issue Apr 22, 2020
@blackboxsw
tox.ini: bump pyflakes version to 2.2.0 (#1038)
2d049f6 
pyflakes versions older than 2.1.0 are incompatible with Python 3.8
(which is the Python version in the Focal release).
See PyCQA/pyflakes#367 for details.

2.2.0 is the latest version ATM, so bump to that.

Fixes: #1023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Testing related items
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tox.ini: bump pyflakes version to 2.2.0 blackboxsw/ubuntu-advantage-client
1 participant
@blackboxsw