Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit notices requests to 20 at most #170

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Limit notices requests to 20 at most #170

merged 1 commit into from
Jul 30, 2024

Conversation

samhotep
Copy link
Member

Done

  • Added a hard limit to how many notices can be requested.
  • This is to reduce the pressure on the backend to assemble and serve very large json payloads.

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8030/
  • Run through the following [QA steps](https://canonical-web-and-design.github
    .io/practices/workflow/qa-steps.html)
  • Request more than 20 notices e.g.
  • /security/notices.json?limit=21
    • Request fewer than 20 notices e.g.
  • /security/notices.json?limit=19

@samhotep samhotep requested a review from mtruj013 July 25, 2024 09:11
@samhotep samhotep changed the title Limited notices requests to 20 at most Limit notices requests to 20 at most Jul 25, 2024
Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samhotep samhotep merged commit 4fa0ae9 into main Jul 30, 2024
5 checks passed
@samhotep samhotep deleted the limit-to-20-notices branch July 30, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants