-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve notices endpoint #146
Conversation
95ac3c1
to
0fd7100
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 85.00% 85.85% +0.85%
==========================================
Files 29 29
Lines 1480 1570 +90
==========================================
+ Hits 1258 1348 +90
Misses 222 222
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
FWIW, there's been a few timeout related issues in the past, some of it being resolved by reducing the query limit. Hopefully this fixes the DB query itself and for good. Here are some: I'm not sure if we can improve cacheability of these requests as well. This would reduce the backend load and have the fronting content-cache units service requests from their local cache. |
29aa9ed
to
6b7c018
Compare
I suppose this is causing canonical/ubuntu.com#13956 |
Done
Querying notices takes quite a while to complete, ~15s on average. This PR hopes to improve the db query by reworking how the notice json is built.
QA
./run serve
Notes