Add way for users to configure block-probing timeout #2073
Conversation
Subiquity (the server) now supports two new options that allow one to configure the block probing timeout: Disable the timeout completely: * --no-block-probing-timeout Set the timeout to a specific value (in seconds) * --block-probing-timeout 180 Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
Users can now set configuration on the subiquity snap. Currently we support configuring the block probing tiemout only. To set the timeout to a specific value: * snap set subiquity block-probing-timeout=180 To disable the timeout: * snap set subiquity block-probing-timeout=no To revert to the default: * snap unset subiquity block-probing-timeout Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
|
CC @d-loose if this change is accepted, I would like to do the same in the ubuntu-desktop-bootstrap snap (desktop is the main driver for this). |
There was a problem hiding this comment.
I thought "wow that looks a bit complicated" and then realized that the snap config bits are pretty much straight from the documentation! ho hum
Did you consider having the subiquity process dynamically fetch the snap value rather than this command line arg / restart server game? I guess that's harder to use in dry run mode.
Yeah, I expected a way to declare the supported variables in the snapcraft.yaml and not write all these scripts but apparently there's no way around it..
The idea didn't cross my mind but it's surely a good idea. I think we need to update more of the code to support the timeout update without restart though. But will consider doing this later! (if we don't get rid of the timeout completely) |
…822) Port of canonical/subiquity#2073 to ubuntu-desktop bootstrap.
Subiquity now supports two new options:
--no-block-probing-timeoutto disable the block-probing timeout completely--block-probing-timeout <seconds>to set the timeout to a specific valueIn addition, we now make the subiquity snap configurable so that this CLI options can be used without modifying the snap.
To disable the timeout:
snap set subiquity block-probing-timeout=noTo set the timeout to a different value:
snap set subiquity block-probing-timeout=180To reset the timeout to the default value:
snap unset subiquity block-probing-timeoutBased on the current snap configuration, the wrapper script (e.g., bin/subiquity-server) will invoke subiquity either with the
--no-block-probing-timeoutoption, the--block-probing-timeout <seconds>option, or none).