Fix some deprecation warnings on core24 #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urwid deprecated the user of the user_arg parameter of connect_signal (and might get dropped sometime). Instead, the suggested approach is to use user_args (plural!) as a kw-only argument. We have to change the signature of callbacks functions because `user_args` is passed as an argument at the beginning ; whereas `user_arg` is passed as an argument at the end. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
urwid deprecated AttrWrap in favor of AttrMap. It is pretty easy to replace one with the other and is backward compatible with urwid from core22. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
urwid from core24 raises deprecation notices when using set_focus on widgets. In core24, one can use the `container.focus = widget` setter property or `container.focus_position = index` setter property. However, in core22, the `container.focus` property is read-only. `container.focus_position` is available in core22 and core24 and does not produce deprecation warnings ; so let's use it. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
Although ListBox.get_focus() is deprecated, using ListWalker.get_focus() through ListBox.body.get_focus() is not. However, the ListBox.focus property exists and makes it easy to access the underlying focused widget ; so use it instead of dereferencing the ListWalker object. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
ogayot
force-pushed
the
urwid-core24-deprecations
branch
from
4fd089a
to
38315ad
Compare
mwhudson
approved these changes
Aug 28, 2024
That sounds like a lot of work! We're using on_press everywhere. Maybe we subclass urwid.Button, and do something like: class Button(urwid.Button):
def __init__(self, *args, on_press=None, user_args=(), **kwargs) -> None:
if "user_data" in kwargs:
raise ValueError("For this implementation, use user_args instead")
super().__init__(*args, **kwargs)
if on_press is not None:
connect_signal(self, "click", on_press, user_args=list(user_args))and then adjust the argument order. Something for another day, I guess :) |
Oh definitely, nothing for this branch!! |
Looking at most of our actual uses, having a wrapper that discarded the 'sender' argument to the callback would be useful .... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On oracular, this PR makes
make unitproduce 59 warnings instead of 146. The remaining warnings (emitted multiple times) are:-> should be addressed with https://launchpad.net/ubuntu/+source/pymongo/4.7.3-1 (won't be addressed for core24 probably though)
-> to be investigated
-> internal to urwid, when using on_press or on_state_change. Won't be fixed anytime soon.