Refactor stages.Init() code path #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Peterson444
force-pushed
the
refactor-cc-stages-init
branch
from
eb6eb24
to
790108d
Compare
dbungert
approved these changes
Aug 29, 2024
Replace the legacy stages.Init() code path with a helper function to call the system_scripts extraction script and get the necessary data (cloud-config + installer_user_name) from there.
Chris-Peterson444
force-pushed
the
refactor-cc-stages-init
branch
from
790108d
to
7faf065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #2026. New changes for this PR are the last four commits.#2026 now part of main. All commits are for this PR.I pulled out the
stages.Init()path from the server code and moved it to a helper script in system_scripts. The idea is that we can call this script and parse the output from it for the same information. It currently prints yaml to stdout, which seems robust enough for the kind of data it returns.I tested this with the Focal release ISO, the 20.04.1 ISO, and the 22.04.1 ISO, all of which would rely on this code path. I tested by:
All scenarios worked as expected.