storage: lean on systemd-shutdown to export zpools on shutdown #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People have reported issues involving non exported zpools at the end of Ubuntu installations. Diagnosing such issues is tricky because the `zpool export` commands have to run after the target is unmounted. And once the target is unmounted, logs can no longer be copied over to the target so bug reports don't include traces of potential `zpool export` failures (or failures to unmount target). Instead of relying on Subiquity's _pre_shutdown hook, we now make use of systemd-shutdown to export the zpools. The chance of successfully exporting the zpools is expected to be higher since it will happen later in the shutdown sequence ; after more mounts have been detached. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
dbungert
approved these changes
Aug 26, 2024
| if not cmds: | ||
| return | ||
|
|
||
| shutdown_dir = root / "usr/lib/systemd/system-shutdown" |
There was a problem hiding this comment.
nitpick: in etc instead? I think this only matters though if the install environment /usr is RO, which is well outside our assumptions.
There was a problem hiding this comment.
Yes, /etc (or even /run - which I wanted initially) feels cleaner but systemd-shutdown only supports /usr it seems.
Chris-Peterson444
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People have reported issues involving non exported zpools at the end of Ubuntu installations. Diagnosing such issues is tricky because the
zpool exportcommands have to run after the target is unmounted. And once the target is unmounted, logs can no longer be copied over to the target so bug reports don't include traces of potentialzpool exportfailures (or failures to unmount target).Instead of relying on Subiquity's _pre_shutdown hook, we now make use of systemd-shutdown to export the zpools. The chance of successfully exporting the zpools is expected to be higher since it will happen later in the shutdown sequence ; after more mounts have been detached.
This is an attempt to fix LP:#2073772 but since I never reproduced the issue, I can't tell if that would actually fix it.