spread: add support to define a custom bios with the qemu backend #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some tests it is important to customize the bios that qemu uses. One example is the Ubuntu Core 20 project. For the spread testing there we need a qemu that uses the OVMF uefi bios. The location of this bios is different on all distributions so defining it in the spread.yaml seems not appropriate.
cmatsuoka
reviewed
Jan 6, 2020
| @@ -118,6 +118,10 @@ func (p *qemuProvider) Allocate(ctx context.Context, system *System) (Server, er | |||
| if os.Getenv("SPREAD_QEMU_GUI") != "1" { | |||
| cmd.Args = append([]string{cmd.Args[0], "-nographic"}, cmd.Args[1:]...) | |||
| } | |||
| if biosPath := os.Getenv("SPREAD_QEMU_BIOS"); biosPath != "" { | |||
| cmd.Args = append([]string{cmd.Args[0], "-bios", biosPath}, cmd.Args[1:]...) | |||
| } | |||
There was a problem hiding this comment.
We may need to use -pflash later when working with secure boot to be able to enroll our keys and certificates to our nvram file (which we'll also need to specify).
mvo5
commented
Mar 3, 2020
| @@ -827,6 +827,10 @@ see the `-pass` command line option). | |||
| The QEMU backend is run with the `-nographic` option by default. This | |||
| may be changed with `export SPREAD_QEMU_GUI=1`. | |||
|
|
|||
| The bios that qemu uses can be changed via the SPREAD_QEMU_BIOS | |||
| environment variable. To switch to an UEFI bios on Ubuntu | |||
| `export SPREAD_QEMU_BIOS=/usr/share/OVMF/OVMF_CODE.ms.fd` can be used. | |||
There was a problem hiding this comment.
This can't be used as is because the bios location is a property of the host. But the images used can be both efi/non-efi and some efi images may need to be booted with a different efi bios. So one global options like this is not granular enough.
There was a problem hiding this comment.
Have you considered adding an optional bios: string for backends.systems in spread.yaml instead?
|
Closing this in favor of #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some tests it is important to customize the bios that qemu
uses. One example is the Ubuntu Core 20 project. For the spread
testing there we need a qemu that uses the OVMF uefi bios.
The location of this bios is different on all distributions so
defining it in the spread.yaml seems not appropriate.