Skip to content

chore: Add build folder to the gitignore list.#617

Closed
odadacharles wants to merge 1 commit into
canonical:mainfrom
odadacharles:ignore-dev-directory
Closed

chore: Add build folder to the gitignore list.#617
odadacharles wants to merge 1 commit into
canonical:mainfrom
odadacharles:ignore-dev-directory

Conversation

@odadacharles

Copy link
Copy Markdown
Contributor
  • Have you updated CHANGELOG.md with relevant non-documentation file changes?
  • Have you updated the documentation for this change?

The _dev folder is a build folder and changes to it should not be committed.

Signed-off-by: Charles Odada <charles.odada@canonical.com>

@jahn-junior jahn-junior left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odadacharles Is there a specific build artifact in the _dev directory that was left out of the .gitignore? If so, can you add it explicitly?

We can't ignore the entire directory, as maintainers will need to make changes and, while it isn't recommended, teams may need to customize the directory's contents.

@odadacharles

Copy link
Copy Markdown
Contributor Author

@jahn-junior Sorry, I hadn't considered that. We've been seeing files in the doctrees folder and a few others. These are handled by running make clean, but I think they should be ignored by default. I'll send you the details on MM since it's from a private repo. I can update this PR tomorrow if the specific changes are valid.

@jahn-junior

Copy link
Copy Markdown
Collaborator

Resolved the issue downstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants