feat: add SP-specific contributing guide#521
Merged
Merged
Conversation
akcano
requested review from
SecondSkoll,
dwilding,
medubelko,
minaelee,
rkratky and
tang-mm
as code owners
dwilding
reviewed
Feb 2, 2026
dwilding
left a comment
dwilding
left a comment
Contributor
There was a problem hiding this comment.
Nice work, thanks! I added several comments and suggestions. The ones I feel strongest about are:
- Making the "Create a development branch" section clearer that contributors (very probably) ought to target
dev - Simplifying the "Review process" section
Co-authored-by: Dave Wilding <tech@dpw.me>
Co-authored-by: Dave Wilding <tech@dpw.me>
jahn-junior
reviewed
Feb 6, 2026
jahn-junior
left a comment
jahn-junior
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This is a great step in defining how we develop from the Starter Pack and what we expect from contributions.
I'm leaving my review as general feedback because it's mostly optional changes and food for thought, with some well-formed suggestions sprinkled here and there.
medubelko
reviewed
Feb 6, 2026
medubelko
approved these changes
Feb 10, 2026
medubelko
left a comment
medubelko
left a comment
Collaborator
There was a problem hiding this comment.
@jahn-junior Did you want to give it an approval before I merge?
jahn-junior
approved these changes
Feb 10, 2026
jahn-junior
left a comment
jahn-junior
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks for all of your hard work on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [ ] Have you updatedCHANGELOG.mdwith relevant non-documentation file changes?This fixes #470.
Rendered doc