You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(Not in the scope of this quick fix, but we should also remove the invocations of wokeignore from the docs :-))
@rkratky I think it makes sense to just re-scope this to remove all misleading mentions of woke. But I'm a little confused because there are three types of mentions besides the .wokeignore file:
make woke, which still exists but invokes Vale instead - so we leave this
The :woke-ignore: role, which is specified in the conf.py - so I assume we also leave this
wokeignore:rule= - is this a remnant from the original woke tool that should be replaced by the :woke-ignore: role?
The :woke-ignore: role, which is specified in the conf.py - so I assume we also leave this
conf.py specifies both vale-ignore and woke-ignore, and I assume the latter is just to have some semblance of continuity from wokeignore. But in the guidance, I'd suggest instructing ppl to use vale-ignore.
wokeignore:rule= - is this a remnant from the original woke tool that should be replaced by the :woke-ignore: role?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
documentationImprovements or additions to documentation
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdwith relevant non-documentation file changes?Removed instructions to delete
.wokeignorefrom the tutorial, since it no longer exists. (#517)Additionally, removed old
wokeignore:rule=directives throughout the docs.