build: update VALEDIR and make it conditional#493
Merged
Conversation
`VALEDIR` represents the package directory for Vale, yet it re-establishes the same path as `VENVDIR`. It makes more sense to compose it from `VENVDIR`. Furthermore, since `VENVDIR` is configurable by the calling environment, it stands to reason that `VALEDIR` should be, too.
medubelko
requested review from
SecondSkoll,
akcano,
dwilding,
minaelee,
rkratky and
tang-mm
as code owners
SecondSkoll
approved these changes
Jan 12, 2026
medubelko
added a commit
to medubelko/sphinx-stack
that referenced
this pull request
Jan 28, 2026
`VALEDIR` represents the package directory for Vale, yet it re-establishes the same path as `VENVDIR`. It makes more sense to compose it from `VENVDIR`. Furthermore, since `VENVDIR` is configurable by the calling environment, it stands to reason that `VALEDIR` should be, too.
medubelko
added a commit
that referenced
this pull request
Jan 28, 2026
`VALEDIR` represents the package directory for Vale, yet it re-establishes the same path as `VENVDIR`. It makes more sense to compose it from `VENVDIR`. Furthermore, since `VENVDIR` is configurable by the calling environment, it stands to reason that `VALEDIR` should be, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VALEDIRrepresents the bin directory for Vale, yet it re-establishes the same path asVENVDIR. It makes more sense to compose it fromVENVDIR.Furthermore, since
VENVDIRis configurable by the calling environment, it stands to reason thatVALEDIRshould be, too.This change makes parent projects like in canonical/starbase#478 run the docs without modifying the Starter Pack's Makefile.
CHANGELOG.mdwith relevant non-documentation file changes?- [ ] Have you updated the documentation for this change?