Fix and improve links#46
Merged
Merged
Conversation
ru-fu
reviewed
Jun 30, 2023
| .. _Canonical website: https://canonical.com/ | ||
| .. _reStructuredText style guide: https://canonical-documentation-with-sphinx-and-readthedocscom.readthedocs-hosted.com/style-guide/ | ||
| .. _Sphinx reStructuredText Primer: https://tinyurl.com/rstprimer | ||
| .. _Sphinx reStructuredText Primer: https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html |
There was a problem hiding this comment.
This one was using tinyurl because it made the woke action fail - seems like there's something wrong with the action now, it shouldn't pass.
There was a problem hiding this comment.
Checked the history, and it made the woke check fail when it was still in the .rst file - but now it's moved out into a .txt file, and so it isn't checked (which makes sense).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two links that were pointing to library.canonical.com . The
linkcheckmake job may not able to detect broken links to that domain due to 2FA.There was also a link that used a URL shortener which is not best practice.