Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
c1fe276
feat: replace spelling check with vale
SecondSkoll Jul 9, 2025
ecfcce7
chore: pin canonical-sphinx version to 0.5.0 release
SecondSkoll Jul 9, 2025
44d75a3
chore: remove unnecessary files
SecondSkoll Jul 9, 2025
cd757cd
chore: bump version
SecondSkoll Jul 9, 2025
26e3a4b
chore: change style guide repo address
SecondSkoll Jul 9, 2025
c473f67
docs: clarify syntax guides
SecondSkoll Jul 9, 2025
a553c29
docs: document vale exceptions and new spelling config
SecondSkoll Jul 9, 2025
4b2aabb
feat: add URL removal check
SecondSkoll Jul 9, 2025
d63d626
chore: remove wordlist
SecondSkoll Jul 9, 2025
0684b02
chore: update changelog
SecondSkoll Jul 9, 2025
730cd46
fix: linting and checks
SecondSkoll Jul 9, 2025
35eae2b
Merge branch 'canonical:main' into main
SecondSkoll Jul 9, 2025
0faa320
fix: linting, spelling
SecondSkoll Jul 9, 2025
97e9b7d
fix: removes URL check
SecondSkoll Jul 14, 2025
4f1a18c
docs: sitemap exceptions
SecondSkoll Jul 14, 2025
6e7a37f
test: correct repo for URL removal check
SecondSkoll Jul 14, 2025
1eede38
docs: updates changelog
SecondSkoll Jul 14, 2025
3eb1f3d
fix: adds redirect for removed URLs
SecondSkoll Jul 14, 2025
3031636
fix(check-removed-urls): use the pull request base repo for the base …
Guillaumebeuzeboc Jul 14, 2025
9d63f0f
docs: syntax guide reference
SecondSkoll Jul 14, 2025
99b454d
chore: remove comment
SecondSkoll Jul 14, 2025
ab2f937
chore: word additions for vale style linting
SecondSkoll Jul 15, 2025
3d2e11e
chore: unpin canonical-sphinx
SecondSkoll Jul 16, 2025
af6525f
Apply suggestions from code review
SecondSkoll Jul 17, 2025
0f9cb56
Update contributing.rst
SecondSkoll Jul 17, 2025
3c2cd99
Apply suggestions from code review
SecondSkoll Jul 17, 2025
9bdf9b4
docs: add prompt to redirect removed pages in check
SecondSkoll Jul 24, 2025
e0e54f8
chore: remove spellcheck install
SecondSkoll Jul 24, 2025
5b16a06
feat: keep alternate spellcheck command to warn of deprecation
SecondSkoll Jul 24, 2025
f13d245
Merge branch 'main' into main
SecondSkoll Jul 24, 2025
4b62f58
fix: makefile backticks fix
SecondSkoll Jul 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions .github/workflows/check-removed-urls.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
name: Check for removed URLs
Comment thread
dwilding marked this conversation as resolved.

on:
pull_request:
branches: [main]

jobs:
build-docs:
runs-on: ubuntu-latest
steps:
- name: Checkout PR branch
uses: actions/checkout@v4
with:
repository: ${{ github.event.pull_request.head.repo.full_name }}
ref: ${{ github.event.pull_request.head.ref }}
fetch-depth: 0
path: compare
- name: Checkout base branch
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.base.ref }}
repository: ${{ github.event.pull_request.base.repo.full_name }}
fetch-depth: 0
path: base
- uses: actions/setup-python@v5
- name: Build docs
run: |
for dir in compare base; do
pushd ${dir}/docs
make install
. .sphinx/venv/bin/activate
make html
popd
done
- name: Generate current URLs list
run: |
for dir in compare base; do
pushd ${dir}/docs
find ./_build/ -name '*.html' \
| sed 's|/_build||;s|/index.html$|/|;s|.html$||' \
| sort > urls.txt
popd
done
- name: Compare URLs
run: |
BASE_URLS_PATH="base/docs/urls.txt"
COMPARE_URLS_PATH="compare/docs/urls.txt"
removed=$(comm -23 ${BASE_URLS_PATH} ${COMPARE_URLS_PATH} )
if [ -n "$removed" ]; then
echo "The following URLs were removed:"
echo "$removed"
Comment thread
SecondSkoll marked this conversation as resolved.
echo "Please ensure removed pages are redirected"
exit 1
fi
14 changes: 11 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,31 @@
# sphinx-docs-starter-pack changelog

## 1.1.1
## 1.2.0

* Replaces spelling check with Vale.
* Fixes the Markdown linting GitHub action and adds a `make lint-md` check.
* Fixes the download branch name in the update script.
* Adds a check for removed URLs.

### Added

* `docs/.sphinx/.pymarkdown.json` [#379](https://github.com/canonical/sphinx-docs-starter-pack/pull/379)
* `.github/workflows/check-removed-urls.yml` [#410](https://github.com/canonical/sphinx-docs-starter-pack/pull/410)

### Changed

* `docs/.sphinx/update_sp.py` [#397](https://github.com/canonical/sphinx-docs-starter-pack/pull/397)
* `docs/.sphinx/update_sp.py` [#397](https://github.com/canonical/sphinx-docs-starter-pack/pull/397) [#410](https://github.com/canonical/sphinx-docs-starter-pack/pull/410)
* `.github/workflows/markdown-style-checks.yml` [#379](https://github.com/canonical/sphinx-docs-starter-pack/pull/379)
* `docs/Makefile` [#379](https://github.com/canonical/sphinx-docs-starter-pack/pull/379)
* `docs/Makefile` [#379](https://github.com/canonical/sphinx-docs-starter-pack/pull/379) [#410](https://github.com/canonical/sphinx-docs-starter-pack/pull/410)
* `docs/requirements.txt` [#410](https://github.com/canonical/sphinx-docs-starter-pack/pull/410)
* `docs/.sphinx/get_vale_conf.py` [#410](https://github.com/canonical/sphinx-docs-starter-pack/pull/410)

### Removed

* `docs/.sphinx/.markdownlint.json` [#379](https://github.com/canonical/sphinx-docs-starter-pack/pull/379)
* `docs/.sphinx/.wordlist.txt` [#410](https://github.com/canonical/sphinx-docs-starter-pack/pull/410)
* `docs/.sphinx/spellingcheck.yaml` [#410](https://github.com/canonical/sphinx-docs-starter-pack/pull/410)


## 1.1.0

Expand Down
16 changes: 16 additions & 0 deletions docs/.custom_wordlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,20 @@ wordlist
xetex
xindy
xml
ip
spread_test_example
Furo
PDF
Open Graph
MyST
YouTube
reStructuredText
GitHub
Sphinx
URL
PR
Read the Docs
Spread
landscape
lastmod
yaml
Loading
Loading