-
Notifications
You must be signed in to change notification settings - Fork 76
1.2.0 release, tidy, and change to vale for spelling #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
c1fe276
feat: replace spelling check with vale
SecondSkoll ecfcce7
chore: pin canonical-sphinx version to 0.5.0 release
SecondSkoll 44d75a3
chore: remove unnecessary files
SecondSkoll cd757cd
chore: bump version
SecondSkoll 26e3a4b
chore: change style guide repo address
SecondSkoll c473f67
docs: clarify syntax guides
SecondSkoll a553c29
docs: document vale exceptions and new spelling config
SecondSkoll 4b2aabb
feat: add URL removal check
SecondSkoll d63d626
chore: remove wordlist
SecondSkoll 0684b02
chore: update changelog
SecondSkoll 730cd46
fix: linting and checks
SecondSkoll 35eae2b
Merge branch 'canonical:main' into main
SecondSkoll 0faa320
fix: linting, spelling
SecondSkoll 97e9b7d
fix: removes URL check
SecondSkoll 4f1a18c
docs: sitemap exceptions
SecondSkoll 6e7a37f
test: correct repo for URL removal check
SecondSkoll 1eede38
docs: updates changelog
SecondSkoll 3eb1f3d
fix: adds redirect for removed URLs
SecondSkoll 3031636
fix(check-removed-urls): use the pull request base repo for the base …
Guillaumebeuzeboc 9d63f0f
docs: syntax guide reference
SecondSkoll 99b454d
chore: remove comment
SecondSkoll ab2f937
chore: word additions for vale style linting
SecondSkoll 3d2e11e
chore: unpin canonical-sphinx
SecondSkoll af6525f
Apply suggestions from code review
SecondSkoll 0f9cb56
Update contributing.rst
SecondSkoll 3c2cd99
Apply suggestions from code review
SecondSkoll 9bdf9b4
docs: add prompt to redirect removed pages in check
SecondSkoll e0e54f8
chore: remove spellcheck install
SecondSkoll 5b16a06
feat: keep alternate spellcheck command to warn of deprecation
SecondSkoll f13d245
Merge branch 'main' into main
SecondSkoll 4b62f58
fix: makefile backticks fix
SecondSkoll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| name: Check for removed URLs | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [main] | ||
|
|
||
| jobs: | ||
| build-docs: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout PR branch | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: ${{ github.event.pull_request.head.repo.full_name }} | ||
| ref: ${{ github.event.pull_request.head.ref }} | ||
| fetch-depth: 0 | ||
| path: compare | ||
| - name: Checkout base branch | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.pull_request.base.ref }} | ||
| repository: ${{ github.event.pull_request.base.repo.full_name }} | ||
| fetch-depth: 0 | ||
| path: base | ||
| - uses: actions/setup-python@v5 | ||
| - name: Build docs | ||
| run: | | ||
| for dir in compare base; do | ||
| pushd ${dir}/docs | ||
| make install | ||
| . .sphinx/venv/bin/activate | ||
| make html | ||
| popd | ||
| done | ||
| - name: Generate current URLs list | ||
| run: | | ||
| for dir in compare base; do | ||
| pushd ${dir}/docs | ||
| find ./_build/ -name '*.html' \ | ||
| | sed 's|/_build||;s|/index.html$|/|;s|.html$||' \ | ||
| | sort > urls.txt | ||
| popd | ||
| done | ||
| - name: Compare URLs | ||
| run: | | ||
| BASE_URLS_PATH="base/docs/urls.txt" | ||
| COMPARE_URLS_PATH="compare/docs/urls.txt" | ||
| removed=$(comm -23 ${BASE_URLS_PATH} ${COMPARE_URLS_PATH} ) | ||
| if [ -n "$removed" ]; then | ||
| echo "The following URLs were removed:" | ||
| echo "$removed" | ||
|
SecondSkoll marked this conversation as resolved.
|
||
| echo "Please ensure removed pages are redirected" | ||
| exit 1 | ||
| fi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.