Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces/hotplug: add hotplug Specification and HotplugDeviceInfo #5416

Merged
merged 22 commits into from
Jul 5, 2018
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
275f7ad
Added hotplug Specification and HotplugDeviceInfo.
stolowski Jun 27, 2018
280ed48
Merge branch 'master' into hotplug-device-info
stolowski Jun 28, 2018
8163720
Merge branch 'master' into hotplug-device-info
stolowski Jun 28, 2018
1edbf70
Review feedback.
stolowski Jun 28, 2018
9a5f9da
Removed type HotplugDeviceHandler type definition for now.
stolowski Jun 28, 2018
63b33d0
Updated HotPlugSpec.
stolowski Jun 28, 2018
07adf32
Merge branch 'master' into hotplug-device-info
stolowski Jun 28, 2018
7dd7efe
Merge branch 'master' into hotplug-device-info
stolowski Jun 29, 2018
e408116
Merge branch 'master' into hotplug-device-info
stolowski Jun 29, 2018
e3adc77
Merge branch 'master' into hotplug-device-info
stolowski Jun 29, 2018
23e8ec6
Merge branch 'master' into hotplug-device-info
stolowski Jun 29, 2018
06eb95c
Sort slots.
stolowski Jun 29, 2018
4c637dd
Review comments.
stolowski Jun 29, 2018
4c23113
More comments.
stolowski Jun 29, 2018
ee9c8b6
Made data private, added generic Attribute getter.
stolowski Jun 29, 2018
dc6a005
Added Definer type.
stolowski Jul 2, 2018
4bff39a
Merge branch 'master' into hotplug-device-info
stolowski Jul 2, 2018
7ceb603
Merge branch 'master' into hotplug-device-info
stolowski Jul 4, 2018
9c027cf
Validate interface name in the hotplug spec.
stolowski Jul 4, 2018
8d1b22d
Drop Object attribute from HotplugDeviceInfo. Use snap.ValidateSlotName.
stolowski Jul 5, 2018
00276aa
Reverted the addition of ValidateName.
stolowski Jul 5, 2018
237c82b
Check that DEVPATH exists.
stolowski Jul 5, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed type HotplugDeviceHandler type definition for now.
  • Loading branch information
stolowski committed Jun 28, 2018
commit 9a5f9da544530025a6330bbb0134a86e9cce6315
5 changes: 0 additions & 5 deletions interfaces/hotplug/deviceinfo.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,3 @@ func (h *HotplugDeviceInfo) DeviceName() string {
func (h *HotplugDeviceInfo) DeviceType() string {
return h.Data["DEVTYPE"]
}

// HotplugDeviceHandler can be implemented by interfaces that need to create slots in response to hotplug events
type HotplugDeviceHandler interface {
HotplugDeviceDetected(di *HotplugDeviceInfo, spec *Specification) error
}