daemon: use client.Snap instead of map[string]interface{} for snaps. #3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small refactoring branch that drops the hacky and error-prone
`map[string]interface{}` and switches to use client.Snap.
This should make asking for some fields easier, which is what I was looking at
when the need for this arose.
Codecov Report
@@ Coverage Diff @@
## master #3968 +/- ##
==========================================
+ Coverage 75.96% 75.98% +0.01%
==========================================
Files 423 423
Lines 36525 36505 -20
==========================================
- Hits 27748 27737 -11
+ Misses 6836 6830 -6
+ Partials 1941 1938 -3
Continue to review full report at Codecov.
|
zyga
approved these changes
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small refactoring branch that drops the hacky and error-prone
map[string]interface{}and switches to use client.Snap.This should make asking for some fields easier, which is what I was looking at
when the need for this arose.