many: add logger.MockLogger() and use it in the tests #3911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some noise in the unittest runs right now because messages get logged to stdout which really should not be visible. With the new logger.MockLogger() they are now no longer visible.
Codecov Report
@@ Coverage Diff @@
## master #3911 +/- ##
==========================================
+ Coverage 75.9% 75.91% +0.01%
==========================================
Files 416 416
Lines 35986 35994 +8
==========================================
+ Hits 27316 27326 +10
+ Misses 6752 6751 -1
+ Partials 1918 1917 -1
Continue to review full report at Codecov.
|
pedronis
approved these changes
Sep 13, 2017
logger/logger.go
Outdated
| } | ||
| SetLogger(l) | ||
| return buf, func() { | ||
| logger = oldLogger |
logger/logger.go
Outdated
| // MockLogger replaces the exiting logger with a buffer and returns | ||
| // the log buffer and a restore function. | ||
| func MockLogger() (buf *bytes.Buffer, restore func()) { | ||
| buf = bytes.NewBuffer(nil) |
There was a problem hiding this comment.
this is just: &bytes.Buffer{}
chipaca
approved these changes
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two noisy tests in the unittest runs right now. Messages
get logged to stdout which really should not be visible. With the use
of the new logger.MockLogger() those are now no longer visible.
I also tweaked the existing pattern of:
to just use:
Please let me know what you think, if you think this simple setup should not have a MockLogger() helper I'm happy to adjust the PR to just switch to a different logger in the two noisy tests we currently have.