Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secboot: bump secboot to rev e07f4ae48e98 #15127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

secboot: bump secboot to rev e07f4ae48e98 #15127

wants to merge 2 commits into from
+5 −4

Conversation

bboozzoo
Copy link
Contributor

Bump secboot to include a fix from
canonical/secboot#384

@bboozzoo bboozzoo added the Run nested The PR also runs tests inluded in nested suite label Feb 25, 2025
@bboozzoo bboozzoo added this to the 2.68.2 milestone Feb 25, 2025
ernestl
ernestl approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@ernestl ernestl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ernestl ernestl removed the request for review from valentindavid February 25, 2025 14:47
@codecov Codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (a272aac) to head (4a58c03).
Report is 52 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15127      +/-   ##
==========================================
- Coverage   78.07%   77.84%   -0.23%     
==========================================
  Files        1182     1171      -11     
  Lines      157743   157064     -679     
==========================================
- Hits       123154   122272     -882     
- Misses      26943    27185     +242     
+ Partials     7646     7607      -39
Flag Coverage Δ
unittests 77.84% <100.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chrisccoulson
chrisccoulson approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@chrisccoulson chrisccoulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

Wed Feb 26 09:23:34 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/13538262741

Failures:

Preparing:

  • google-nested:ubuntu-24.04-64:tests/nested/manual/hybrid-remodel
  • google-nested:ubuntu-24.04-64:tests/nested/manual/hybrid-fde-dbx
  • google-nested:ubuntu-24.04-64:tests/nested/manual/hybrid-fde-dbx
  • google-nested:ubuntu-24.04-64:tests/nested/manual/hybrid-remodel

Executing:

  • google-nested:ubuntu-18.04-64:tests/nested/manual/minimal-smoke:secboot_enabled
  • google-nested:ubuntu-18.04-64:tests/nested/manual/minimal-smoke:secboot_disabled
  • google-nested:ubuntu-20.04-64:tests/nested/manual/minimal-smoke:secboot_enabled
  • google-nested:ubuntu-20.04-64:tests/nested/manual/minimal-smoke:secboot_disabled
  • google-nested:ubuntu-24.04-64:tests/nested/core/core20-fault-inject-on-refresh:base_reboot_link_snap
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller
  • google-nested:ubuntu-24.04-64:tests/nested/manual/core20-remodel
  • google-nested:ubuntu-24.04-64:tests/nested/manual/split-refresh
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:plain
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:encrypted
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:partial
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:seeded
  • google-nested:ubuntu-24.04-64:tests/nested/core/core20-fault-inject-on-refresh:base_reboot_link_snap
  • google-nested:ubuntu-24.04-64:tests/nested/manual/core20-remodel
  • google-nested:ubuntu-24.04-64:tests/nested/manual/split-refresh
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:seeded
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:partial
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:encrypted
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:plain
  • google-core:ubuntu-core-18-64:tests/core/gadget-kernel-refs-update-pc
  • google-core:ubuntu-core-24-64:tests/core/mem-cgroup-disabled
  • google:ubuntu-24.10-64:tests/main/try

Restoring:

  • google-core:ubuntu-core-24-64:tests/core/mem-cgroup-disabled
  • google-core:ubuntu-core-24-64:tests/core/
  • google-core:ubuntu-core-24-64

pedronis
pedronis approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@bboozzoo
go.mod: bump secboot to rev e07f4ae48e98
ad031b9 
Bump secboot to include a fix from
canonical/secboot#384

Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
@bboozzoo
secboot: update to match canonical/secboot API changes
4a58c03 
Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
@bboozzoo bboozzoo force-pushed the bboozzoo/secboot-bump branch from 8b4e3a6 to 4a58c03 Compare February 26, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisccoulson chrisccoulson chrisccoulson approved these changes

@pedronis pedronis pedronis approved these changes

@ernestl ernestl ernestl approved these changes

Assignees
No one assigned
Labels
Run nested The PR also runs tests inluded in nested suite
Projects
None yet
Milestone
2.68.2
Development

Successfully merging this pull request may close these issues.
4 participants
@bboozzoo @chrisccoulson @pedronis @ernestl