Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add switch to move executions between google and openstack #15122

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sergiocazzolato
Copy link
Collaborator

@sergiocazzolato sergiocazzolato commented Feb 24, 2025

Through this change it is possible to determine if the alternative backend has to be used for the a group in the ci
Alternative backends usage depends on the value stored in the file USE_ALTERNATIVE_BACKEND, where it is defined the backend to use when images are ready in both google and openstack.

The content for USE_ALTERNATIVE_BACKEND is:
opensuse: false,
debian-not-req: false,
centos: false,
ubuntu-jammy: false,
ubuntu-focal (fundamental): false,
ubuntu-noble (fundamental): false

In case we need to swith a group, we just need to change false by true

@maykathm
Copy link
Contributor

I think you're missing the piece that passes the alternative-backend entry to the spread-tests.yaml workflow. I believe it should be something like:

    uses: ./.github/workflows/spread-tests.yaml
    with:
      runs-on: '["self-hosted", "spread-enabled"]'
      group: ${{ matrix.group }}
      backend: ${{ matrix.backend }}
      alternative-backend: ${{ matrix.alternative-backend }}
      systems: ${{ matrix.systems }}
      tasks: ${{ matrix.tasks }}
      rules: ${{ matrix.rules }}

Unfortunately, that will mean that alternative-backend entry has to be present in every other group in the jsons, otherwise the test.yaml will break.

Copy link

github-actions bot commented Feb 25, 2025

Wed Feb 26 16:23:45 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/13546745136

Failures:

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.07%. Comparing base (a272aac) to head (67940b8).
Report is 59 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #15122    +/-   ##
========================================
  Coverage   78.07%   78.07%            
========================================
  Files        1182     1183     +1     
  Lines      157743   158157   +414     
========================================
+ Hits       123154   123480   +326     
- Misses      26943    27005    +62     
- Partials     7646     7672    +26     
Flag Coverage Δ
unittests 78.07% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Katie May <63071677+maykathm@users.noreply.github.com>
@sergiocazzolato sergiocazzolato force-pushed the tests-move-between-google-and-openstack branch from 12f4db6 to 7d1553f Compare February 26, 2025 14:54
@sergiocazzolato sergiocazzolato force-pushed the tests-move-between-google-and-openstack branch from 7d1553f to 3628cf7 Compare February 26, 2025 14:55
This is needed because the vars are not shared to forked environments
@sergiocazzolato sergiocazzolato force-pushed the tests-move-between-google-and-openstack branch from 603d098 to 67940b8 Compare February 26, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants