-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
o/snapstate: include store url in snap setup and auxinfo stored on disk #15040
o/snapstate: include store url in snap setup and auxinfo stored on disk #15040
Conversation
This is a follow-up to f2c208e, which added the "store-url" field to snap auxinfo. However, the caller of keepAuxStoreInfo never actually set the `StoreURL` field, so the auxinfo stored to disk continued to be lacking it. Other related commits are eee4a0e, which set up `cmd/snap` to look for store URL in the local snap's auxinfo, and 25ca263, which included store URL in the store request. Signed-off-by: Oliver Calder <oliver.calder@canonical.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15040 +/- ##
=========================================
Coverage ? 78.02%
=========================================
Files ? 1138
Lines ? 153226
Branches ? 0
=========================================
Hits ? 119558
Misses ? 26303
Partials ? 7365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fri Feb 7 17:42:53 UTC 2025 Failures:Preparing:
Executing:
Restoring:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is a follow-up to f2c208e, which added the "store-url" field to snap auxinfo. However, the caller of keepAuxStoreInfo never actually set the
StoreURL
field, so the auxinfo stored to disk continued to be lacking it.Other related commits are eee4a0e, which set up
cmd/snap
to look for store URL in the local snap's auxinfo, and 25ca263, which included store URL in the store request.To see evidence of the store URL currently being missing from local snap info, see the following (assuming snapd and jq are installed):
In contrast, top-level
"media"
and"website"
fields are always present:This work is tracked internally by https://warthogs.atlassian.net/browse/SNAPDENG-34480