Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix typo in json tags #14895

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

knbr13
Copy link

@knbr13 knbr13 commented Jan 6, 2025

this PR just fixes a typo in the json tags,
from:

`json:"links,omitempy"`

to:

`json:"links,omitempty"`

Copy link

github-actions bot commented Jan 6, 2025

Wed Feb 26 12:45:37 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/13538251820

Failures:

Executing:

  • google:ubuntu-20.04-64:tests/unit/go:clang

Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bboozzoo bboozzoo changed the title fix typo in json tags client: fix typo in json tags Jan 7, 2025
@bboozzoo
Copy link
Contributor

bboozzoo commented Jan 7, 2025

@knbr13 thanks for the patch. Have you already signed the CLA? If not, would you mind following the link from an earlier comment and signing it?

@knbr13
Copy link
Author

knbr13 commented Jan 7, 2025

@knbr13 thanks for the patch. Have you already signed the CLA? If not, would you mind following the link from an earlier comment and signing it?

hi @bboozzoo,
yes, I have signed the CLA yesterday,

@bboozzoo
Copy link
Contributor

@knbr13 can you rebase the branch? there have been some changes to the cla-checker and AFAIU it should be correct now.

@bboozzoo bboozzoo requested review from zyga and ernestl February 24, 2025 14:14
@bboozzoo bboozzoo added this to the 2.68.2 milestone Feb 24, 2025
Copy link
Contributor

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ernestl ernestl force-pushed the fix-typo-in-json-tags branch from bcb7119 to edf2308 Compare February 24, 2025 20:42
@ernestl ernestl closed this Feb 24, 2025
@ernestl ernestl reopened this Feb 24, 2025
@ernestl
Copy link
Collaborator

ernestl commented Feb 24, 2025

Hi @knbr13, thanks for this fix, hope you do not mind, I took the liberty of doing rebase just in the interest of time given we are cutting a new release soon.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.08%. Comparing base (a272aac) to head (cb60db0).
Report is 52 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14895      +/-   ##
==========================================
+ Coverage   78.07%   78.08%   +0.01%     
==========================================
  Files        1182     1185       +3     
  Lines      157743   158111     +368     
==========================================
+ Hits       123154   123467     +313     
- Misses      26943    26974      +31     
- Partials     7646     7670      +24     
Flag Coverage Δ
unittests 78.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernestl
Copy link
Collaborator

ernestl commented Feb 24, 2025

Hi @knbr13, I discussed the CLA issue with the responsible team. The new CLA check action works with CLA submission after its date of release. Would you sign again the CLA https://ubuntu.com/legal/contributors?

@knbr13
Copy link
Author

knbr13 commented Feb 25, 2025

Hi @ernestl,

Thanks for the rebase!
I’ve signed the CLA again as requested.

@ernestl ernestl force-pushed the fix-typo-in-json-tags branch from edf2308 to cb60db0 Compare February 26, 2025 06:57
@ernestl
Copy link
Collaborator

ernestl commented Feb 26, 2025

Rebased again to have latest fix for ARM64 run (using github runner instead of self-hosted runner)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants