-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: fix typo in json tags #14895
base: master
Are you sure you want to change the base?
Conversation
Wed Feb 26 12:45:37 UTC 2025 Failures:Executing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@knbr13 thanks for the patch. Have you already signed the CLA? If not, would you mind following the link from an earlier comment and signing it? |
@knbr13 can you rebase the branch? there have been some changes to the cla-checker and AFAIU it should be correct now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
bcb7119
to
edf2308
Compare
Hi @knbr13, thanks for this fix, hope you do not mind, I took the liberty of doing rebase just in the interest of time given we are cutting a new release soon. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14895 +/- ##
==========================================
+ Coverage 78.07% 78.08% +0.01%
==========================================
Files 1182 1185 +3
Lines 157743 158111 +368
==========================================
+ Hits 123154 123467 +313
- Misses 26943 26974 +31
- Partials 7646 7670 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @knbr13, I discussed the CLA issue with the responsible team. The new CLA check action works with CLA submission after its date of release. Would you sign again the CLA https://ubuntu.com/legal/contributors? |
Hi @ernestl, Thanks for the rebase! |
edf2308
to
cb60db0
Compare
Rebased again to have latest fix for ARM64 run (using github runner instead of self-hosted runner) |
this PR just fixes a typo in the json tags,
from:
to: