tests: fix snapd-snap test #14788
Merged
tests: fix snapd-snap test #14788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is currently failing because we use the deb from the repository which is 2.66.1+2x.04 and the snap version is 2.66.1. This produces that the re-execution is not done and the check for re-exec fails. Also I removed code for systems which are not supported anymore in that test.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14788 +/- ##
==========================================
+ Coverage 78.95% 79.03% +0.08%
==========================================
Files 1084 1087 +3
Lines 146638 147881 +1243
==========================================
+ Hits 115773 116879 +1106
- Misses 23667 23764 +97
- Partials 7198 7238 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zyga
approved these changes
Dec 3, 2024
|
Changed milestone to 2.68, at this stage I do not want to retrigger snapd 2.67 spread tests again. Will reference this ticket to explain the failure is understood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is currently failing because we use the deb from the repository which is 2.66.1+2x.04 and the snap version is 2.66.1. This produces that the re-execution is not done and the check for re-exec fails.
Also I removed code for systems which are not supported anymore in that test.