tests: added the run nested auto label to run spread condition #14586
Conversation
maykathm
added
the
Run Nested -auto-
| @@ -879,7 +879,7 @@ jobs: | |||
| done | |||
|
|
|||
| - name: Run spread tests | |||
| if: "!contains(github.event.pull_request.labels.*.name, 'Skip spread') && ( !startsWith(matrix.group, 'nested-') || contains(github.event.pull_request.labels.*.name, 'Run nested') )" | |||
| if: "!contains(github.event.pull_request.labels.*.name, 'Skip spread') && ( !startsWith(matrix.group, 'nested-') || contains(github.event.pull_request.labels.*.name, 'Run nested') || contains(github.event.pull_request.labels.*.name, 'Run Nested -auto-'))" | |||
There was a problem hiding this comment.
'Run Nested -auto-' is not being matched by contains(github.event.pull_request.labels.*.name, 'Run nested') ?
There was a problem hiding this comment.
It is not. I verified with a debug run that that condition is false in the case of Run Nested -auto-. Here's a run from the PR where I noticed the problem. The "Run Nested -auto-" tag had been added 3 commits prior and I verified with a debug run that the github runner did in fact pick up that label.
I believe in this case the "contains" function is a list contains not a string contains. If it serves double duty with the same call, then I would guess the problem to be a case problem "Nested" vs. "nested". I didn't actually check which of the two possibilities was the actual issue since it seemed easier to add the additional case.
|
No longer relevant after PR #14519 |
The "Run Nested -auto-" tag wasn't running the spread tests. This adds that label to the run condition.