many: add support for user daemons in "snapctl services" #13806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Needs Documentation -auto-
…ng the same --user/--global switches as "snap services"
Meulengracht
force-pushed
the
feature/user-services-snapctl-status
branch
from
0586d29 to
056d30c
Compare
ernestl
approved these changes
Apr 11, 2024
| if isGlobal { | ||
| return servicestate.NewStatusDecorator(progress.Null) | ||
| } else { | ||
| return servicestate.NewStatusDecoratorForUid(progress.Null, ctx, uid) |
There was a problem hiding this comment.
This route is not covered in testing.
There was a problem hiding this comment.
This function is mocked intentionally - if we use NewStatusDecoratorForUid then it will start to contact the snapd user client session which is unfortunate to start spinning up in all tests that use this. Instead the mock verifies that newStatusDecorator is invoked with the expected arguments, and fakes the responses from from the status decorator.
The NewStatusDecoratorForUid functionality, along with the user-session agent is tested independently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce matching functionality for "snapctl services" as in "snap services" by this PR #13381.
"Snapctl services" is one of the few commands that can run without being root user, which means we cannot make any assumptions around the user running the command, introducing the same decision logic around how to deal with the caller.