Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o/hookstate/ctlcmd: introduce --user, --system and --users switches for snap service operations #13696

Merged

Conversation

Meulengracht
Copy link
Member

This is the snapctl version of #13368 and based on top of it to reuse some of the code from that PR.

@github-actions github-actions bot added the Needs Documentation -auto- Label automatically added which indicates the change needs documentation label Mar 13, 2024
@Meulengracht Meulengracht force-pushed the feature/user-services-ctlcmd branch from 9b84854 to db85453 Compare March 13, 2024 14:20
@Meulengracht Meulengracht marked this pull request as ready for review March 13, 2024 14:20
@Meulengracht Meulengracht force-pushed the feature/user-services-ctlcmd branch from 2dcc9a6 to 5fa82a9 Compare March 14, 2024 07:32
Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, couple of comments

overlord/hookstate/ctlcmd/service_scope.go Outdated Show resolved Hide resolved
overlord/hookstate/ctlcmd/services_test.go Show resolved Hide resolved
@Meulengracht Meulengracht requested a review from pedronis March 14, 2024 09:48
@Meulengracht Meulengracht force-pushed the feature/user-services-ctlcmd branch from 166f1e2 to b73a1b5 Compare March 14, 2024 09:51
Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@Meulengracht Meulengracht requested a review from bboozzoo March 14, 2024 13:46
Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Meulengracht Meulengracht added this to the 2.62 milestone Mar 14, 2024
@Meulengracht Meulengracht force-pushed the feature/user-services-ctlcmd branch from b73a1b5 to 405b411 Compare March 14, 2024 14:47
@Meulengracht Meulengracht merged commit de453d0 into canonical:master Mar 14, 2024
37 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation -auto- Label automatically added which indicates the change needs documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants