client: fix specificErr handling in SnapshotExport() #13001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was checking generating a `specificErr` but then checked
`if err != nil {` (and not check for specificErr) and also lacked
a unit test.
When adding the code test it became clear that the other issue
there is that the response body was never read so r.err() would
always return nil.
This commit fixes both issues.
mvo5
added
Simple 😃
| @@ -142,6 +142,15 @@ func (cs *clientSuite) TestClientCheckSnapshots(c *check.C) { | |||
| func (cs *clientSuite) TestClientRestoreSnapshots(c *check.C) { | |||
| cs.testClientSnapshotAction(c, "restore", cs.cli.RestoreSnapshots) | |||
| } | |||
| func (cs *clientSuite) TestClientExportSnapshotSpecificErr(c *check.C) { | |||
There was a problem hiding this comment.
Should we have also a test where the body is not json formatted?
There was a problem hiding this comment.
Yes, I think that would be good, I will see if I can do a small followup here.
miguelpires
approved these changes
Jul 25, 2023
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #13001 +/- ##
==========================================
+ Coverage 78.67% 78.69% +0.01%
==========================================
Files 999 1000 +1
Lines 123889 124140 +251
==========================================
+ Hits 97474 97691 +217
- Misses 20279 20300 +21
- Partials 6136 6149 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alexmurray
pushed a commit
to alexmurray/snapd
that referenced
this pull request
Oct 17, 2023
* client: fix specificErr handling in SnapshotExport()
The code was checking generating a `specificErr` but then checked
`if err != nil {` (and not check for specificErr) and also lacked
a unit test.
When adding the code test it became clear that the other issue
there is that the response body was never read so r.err() would
always return nil.
This commit fixes both issues.
* client: fix TestClientExportSnapshotSpecificErr naming
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
---------
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was checking generating a
specificErrbut then checkedif err != nil {(and not check for specificErr) and also lacked a unit test.When adding the code test it became clear that the other issue there is that the response body was never read so r.err() would always return nil.
This commit fixes both issues.