asserts: add support for account-key constraints #12988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and take them into account when verifying assertion signatures
Meulengracht
reviewed
Aug 2, 2023
Comment on lines
+276
to
+283
| t, ok := hm["type"] | ||
| if !ok { | ||
| return nil, fmt.Errorf("type header constraint mandatory in asserions constraints") | ||
| } | ||
| tstr, ok := t.(string) | ||
| if !ok { | ||
| return nil, fmt.Errorf("type header constraint must be a string") | ||
| } |
There was a problem hiding this comment.
the issue doing that would be less specific errors
olivercalder
approved these changes
Aug 2, 2023
| } | ||
|
|
||
| func accountKeyFormatAnalyze(headers map[string]interface{}, body []byte) (formatnum int, err error) { | ||
| formatnum = 0 |
There was a problem hiding this comment.
(very nitpick): s/formatnum/formatNum ?
There was a problem hiding this comment.
historically the code uses formatnum consistently
mvo5
approved these changes
Aug 4, 2023
alexmurray
pushed a commit
to alexmurray/snapd
that referenced
this pull request
Oct 17, 2023
and take them into account when verifying assertion signatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and take them into account when verifying assertion signatures