Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlord/h/c/umount: remove handling of required parameter #11266

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

mardy
Copy link
Contributor

@mardy mardy commented Jan 18, 2022

go-flags already does this check. Thanks Miguel for spotting it!

@mardy mardy added Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run labels Jan 18, 2022
go-flags already does this check. Thanks Miguel for spotting it!
Copy link
Contributor

@miguelpires miguelpires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #11266 (3529381) into master (9fde45f) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11266      +/-   ##
==========================================
- Coverage   78.37%   78.37%   -0.01%     
==========================================
  Files         926      926              
  Lines      105602   105599       -3     
==========================================
- Hits        82766    82761       -5     
- Misses      17693    17695       +2     
  Partials     5143     5143              
Flag Coverage Δ
unittests 78.37% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
overlord/hookstate/ctlcmd/umount.go 100.00% <ø> (ø)
overlord/hookstate/hookmgr.go 74.67% <0.00%> (-0.65%) ⬇️
overlord/ifacestate/helpers.go 76.96% <0.00%> (-0.49%) ⬇️
cmd/snap/cmd_debug_state.go 70.18% <0.00%> (-0.46%) ⬇️
store/cache.go 71.15% <0.00%> (+1.92%) ⬆️
osutil/synctree.go 79.24% <0.00%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fde45f...3529381. Read the comment docs.

Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@anonymouse64 anonymouse64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonymouse64 anonymouse64 merged commit a23617c into canonical:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants